Moving DataPipe buffers from __iter__ to instance (self) #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
NivekT
added a commit
that referenced
this pull request
May 6, 2022
ghstack-source-id: 43ba829e0675da98fe2a8c4c73efd0dd6c66edaf Pull Request resolved: #388
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 Note that the CI is expected to fail until that PR lands [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 6, 2022
ghstack-source-id: 0be96c0bb28e2959ae4fd015d16c419c3abd6015 Pull Request resolved: #388
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 Note that the CI is expected to fail until that PR lands [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 18, 2022
ghstack-source-id: 827de5290b332ab5171f044a9714450169333c74 Pull Request resolved: #388
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 18, 2022
ghstack-source-id: 643d13c60d8c8fa21e68be23b371d5ba33df896e Pull Request resolved: #388
NivekT
commented
May 18, 2022
Comment on lines
111
to
112
| if self.buffer: | ||
| self.buffer.clear() |
There was a problem hiding this comment.
Interesting enough the domain CI test for Vision started to fail for a previous commit of this PR. It is raising "ResourceWarning" as you can see in the link below.
https://github.com/pytorch/data/runs/6498262553?check_suite_focus=true
Perhaps we need clear the buffer when the iterator is exhausted? I am adding this line to see if the issue is resolved. Let me know if you have any other thoughts.
There was a problem hiding this comment.
Just tried and clearing the buffer at the end of __iter__ doesn't help.
@pmeier Do you think this is related to pytest or something that is introduced in this PR?
There was a problem hiding this comment.
For reference, here is the thread where we discussed a similar issue:
pytorch/vision#5801
There was a problem hiding this comment.
I am going to ignore the warning and land this based on the previous investigation.
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 18, 2022
ghstack-source-id: 827de5290b332ab5171f044a9714450169333c74 Pull Request resolved: #388
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 19, 2022
ghstack-source-id: c4a55ad83139e8bb7d32881d2bc5675b0392197b Pull Request resolved: #388
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 19, 2022
ghstack-source-id: 2c51e5c0253a2305705ae97e8710116f93fcd1c5 Pull Request resolved: #388
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ejguan
approved these changes
May 19, 2022
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly Differential Revision: [D36519522](https://our.internmc.facebook.com/intern/diff/D36519522) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 19, 2022
ghstack-source-id: c74a7afe7ffbfb82ee99521d3144153ea29759b7 Pull Request resolved: #388
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR impacts
ParagraphAggregatorandIterKeyZipperas they previously have their buffer with the iterator rather than the instance.This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775
Note that the CI is expected to fail until that PR goes into nightly
Differential Revision: D36519522