[datapipe] Pass through kwargs to json.loads call in JsonParser #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The comment of this class suggests the keyword arguments in the constructor will be passed through to the json.loads call. However, `self.kwargs` is not actually passed through to the call. Updated the example in the README too Differential Revision: D37162608 fbshipit-source-id: eaf1cba864ed9f7724d5675008f4df4e1768c02c
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37162608 |
ananthsub
changed the title
ananthsub
changed the title
NivekT
approved these changes
Jun 15, 2022
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Jun 17, 2022
Summary: Pull Request resolved: pytorch#518 The comment of this class suggests the keyword arguments in the constructor will be passed through to the json.loads call. However, `self.kwargs` is not actually passed through to the call. Updated the example in the README too Reviewed By: ejguan Differential Revision: D37162608 fbshipit-source-id: b73a6cfc58befbfabfef3595d9b00cef78852273
ejguan
pushed a commit
that referenced
this pull request
Jun 17, 2022
Summary: Pull Request resolved: #518 The comment of this class suggests the keyword arguments in the constructor will be passed through to the json.loads call. However, `self.kwargs` is not actually passed through to the call. Updated the example in the README too Reviewed By: ejguan Differential Revision: D37162608 fbshipit-source-id: b73a6cfc58befbfabfef3595d9b00cef78852273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The comment of this class suggests the keyword arguments in the constructor will be passed through to the json.loads call. However,
self.kwargsis not actually passed through to the call.Updated the example in the README too
Differential Revision: D37162608