-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples to avoid lambdas #524
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Jun 20, 2022
ghstack-source-id: 9f7d9767a47fa07e4b4f643c62947e1f6e3db76d Pull Request resolved: #524
[ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Jun 20, 2022
ghstack-source-id: eb45fd233c5ab544548ed4506e2e77b073b217ed Pull Request resolved: #524
ejguan
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thank you for fixing them!
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
You can still cherry-pick this PR. PyTorch core postponed the release date. |
NivekT
added a commit
that referenced
this pull request
Jun 20, 2022
Summary: Pull Request resolved: #524 This allow these examples to work with multiprocessing even without `dill` installed. Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D37286086 Pulled By: NivekT fbshipit-source-id: 52c859097f2d3b14d3b78d752e1f01ff5574dca5
This was referenced Jun 20, 2022
NivekT
added a commit
that referenced
this pull request
Jun 20, 2022
Summary: Pull Request resolved: #524 This allow these examples to work with multiprocessing even without `dill` installed. Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D37286086 Pulled By: NivekT fbshipit-source-id: 52c859097f2d3b14d3b78d752e1f01ff5574dca5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This allow these examples to work with multiprocessing even without
dill
installed.Differential Revision: D37286086