Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Habana CompiledFunction should be stateless #2905

Closed
gcatron opened this issue May 14, 2019 · 2 comments
Closed

Habana CompiledFunction should be stateless #2905

gcatron opened this issue May 14, 2019 · 2 comments

Comments

@gcatron
Copy link
Contributor

gcatron commented May 14, 2019

With the addition of DeviceBindings to the ExecutionContext the Habana compiledFunction should be refactored to be stateless. This way the same compiledFunction can be run on multiple cards. Once this is done we can close #1951 .

@bertmaher
Copy link
Contributor

What state needs to be removed, exactly? There's ctx_ (which is unused), but the rest is not mutated during execute()

@bertmaher
Copy link
Contributor

Double checking, HabanaFunction is good to go. It doesn't contain any device-specific or mutable state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants