Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper credits given & licensing in the right way #3324

Closed
DavidNeveziStrango opened this issue Jan 10, 2025 · 5 comments
Closed

Proper credits given & licensing in the right way #3324

DavidNeveziStrango opened this issue Jan 10, 2025 · 5 comments
Labels

Comments

@DavidNeveziStrango
Copy link

❓ Questions/Help/Support

Hey! Im a last year masters student, and i released within an EU-funded project, a part of my masters thesis as a pip package, mainly concerning about embedded AI optimizations. Since i was heavily inspired by ur Checkpoint and Earlystopper classes, i would like to give you the proper credits and also to be in accordance with your license. Due to my university's "ulterior motives" i also did a research paper on my pip package, thus being a matter of importance to me that everything is OK by your side. (Honestly, i have my doubts regarding the license, since the rest of the project is a derivative work of an Apache 2.0 licensed project, so i "inherited" their license, with the specification that some parts have different licenses. You can see the notices on the source code)

My package's repo: https://github.com/DavidNeveziStrango/ubervvald
On the paper, i did mention torch ignite accordingly and left a link to the repository.

Please let me know

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 10, 2025

@DavidNeveziStrango thanks for mentioning pytorch-ignite. To cite the project in the paper, you can use the block from: https://github.com/pytorch/ignite?tab=readme-ov-file#citing-ignite

@DavidNeveziStrango
Copy link
Author

@vfdev-5 Made the modification about citation according as you mentioned above.

I will be waiting then for your approval of license handling (if you cannot find them, it is in the init and in the _utils python files)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 10, 2025

I will be waiting then for your approval of license handling (if you cannot find them, it is in the init and in the _utils python files)

OK to me.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 10, 2025

Why not using pytorch-ignite package instead of copying the code source ?

@DavidNeveziStrango
Copy link
Author

Honestly, at first i had a more basic version of those functionalities, so i needed something a bit better. However, due to lack of time and meeting deadlines, i couldnt start to learn and experiment with ignite, seeing that it is mainly for distributed computing at first glance, so i rather went with the idea to adapt those functionalities to my own need.

Nevertheless, i do not exclude the possibility of integrating ignite in the future.
Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants