Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

deprecation of number for octokit #62

Open
seemethere opened this issue Sep 1, 2021 · 1 comment
Open

deprecation of number for octokit #62

seemethere opened this issue Sep 1, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@seemethere
Copy link
Member

Affects auto-cc-bot:

      Deprecation: [@octokit/rest] "number" parameter is deprecated for ".issues.get()". Use "issue_number" instead
          at /home/runner/work/pytorch-probot/pytorch-probot/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/register-endpoints.js:47:34
          at Array.forEach (<anonymous>)
          at Object.forEach [as get] (/home/runner/work/pytorch-probot/pytorch-probot/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/register-endpoints.js:44:30)
          at CachedIssueTracker.<anonymous> (/home/runner/work/pytorch-probot/pytorch-probot/src/utils.ts:57:55)
          at step (/home/runner/work/pytorch-probot/pytorch-probot/src/utils.ts:46:23)
          at Object.next (/home/runner/work/pytorch-probot/pytorch-probot/src/utils.ts:27:53)
          at fulfilled (/home/runner/work/pytorch-probot/pytorch-probot/src/utils.ts:18:58)

See https://github.com/pytorch/pytorch-probot/runs/3488345303

@seemethere seemethere added the good first issue Good for newcomers label Sep 1, 2021
@malfet
Copy link
Contributor

malfet commented Sep 2, 2021

Actually, I closed this one by 6f6a5b3

But few more remains, for example:

      Deprecation: [@octokit/rest] "number" parameter is deprecated for ".issues.update()". Use "issue_number" instead
          at /home/runner/work/pytorch-probot/pytorch-probot/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/register-endpoints.js:47:34
          at Array.forEach (<anonymous>)
          at Object.forEach [as update] (/home/runner/work/pytorch-probot/pytorch-probot/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/register-endpoints.js:44:30)
          at /home/runner/work/pytorch-probot/pytorch-probot/src/auto-cc-bot.ts:61:39
          at step (/home/runner/work/pytorch-probot/pytorch-probot/src/auto-cc-bot.ts:33:23)
          at Object.next (/home/runner/work/pytorch-probot/pytorch-probot/src/auto-cc-bot.ts:14:53)
          at fulfilled (/home/runner/work/pytorch-probot/pytorch-probot/src/auto-cc-bot.ts:5:58)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants