-
Notifications
You must be signed in to change notification settings - Fork 23.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataPipe] Improving debug message when argument is a tuple/list of DataPipes #76134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ataPipes [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0d221b4 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
ejguan
reviewed
Apr 20, 2022
…e/list of DataPipes" The previous PR #75618 neglected to handle the case where the argument is a tuple/list of DataPipes, as it is the case for `zip`, `mux`, etc. This PR addresses that issue. Now the message looks like the following, instead of a bunch of `<...>` inside the tuple. ``` This exception is thrown by __iter__ of ZipperIterDataPipe(datapipes=(IterableWrapperIterDataPipe, IterableWrapperIterDataPipe, IterableWrapperIterDataPipe)) ``` [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Apr 20, 2022
…ataPipes ghstack-source-id: a301a302da95879decf6febecb61771de903f048 Pull Request resolved: #76134
ejguan
reviewed
Apr 20, 2022
…e/list of DataPipes" The previous PR #75618 neglected to handle the case where the argument is a tuple/list of DataPipes, as it is the case for `zip`, `mux`, etc. This PR addresses that issue. Now the message looks like the following, instead of a bunch of `<...>` inside the tuple. ``` This exception is thrown by __iter__ of ZipperIterDataPipe(datapipes=(IterableWrapperIterDataPipe, IterableWrapperIterDataPipe, IterableWrapperIterDataPipe)) ``` [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Apr 21, 2022
…ataPipes ghstack-source-id: 3db71b38876f8b620b8c595cd7db8c5776bbdf3f Pull Request resolved: #76134
…e/list of DataPipes" The previous PR #75618 neglected to handle the case where the argument is a tuple/list of DataPipes, as it is the case for `zip`, `mux`, etc. This PR addresses that issue. Now the message looks like the following, instead of a bunch of `<...>` inside the tuple. ``` This exception is thrown by __iter__ of ZipperIterDataPipe(datapipes=(IterableWrapperIterDataPipe, IterableWrapperIterDataPipe, IterableWrapperIterDataPipe)) ``` [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Apr 21, 2022
…ataPipes ghstack-source-id: d5573b85eb9bc8d8028d00f303ca5574292b0534 Pull Request resolved: #76134
ejguan
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you
…e/list of DataPipes" The previous PR #75618 neglected to handle the case where the argument is a tuple/list of DataPipes, as it is the case for `zip`, `mux`, etc. This PR addresses that issue. Now the message looks like the following, instead of a bunch of `<...>` inside the tuple. ``` This exception is thrown by __iter__ of ZipperIterDataPipe(datapipes=(IterableWrapperIterDataPipe, IterableWrapperIterDataPipe, IterableWrapperIterDataPipe)) ``` [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Apr 22, 2022
…ataPipes ghstack-source-id: 684c16d50fa97651907bcae2c357fe44be8703c9 Pull Request resolved: #76134
@pytorchbot merge this please |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
…ataPipes (#76134) Summary: Pull Request resolved: #76134 Approved by: https://github.com/ejguan Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ed8e498c7058e0c9d61ffdf883daa3d10f9d2b43 Reviewed By: seemethere, osalpekar Differential Revision: D35874484 Pulled By: NivekT fbshipit-source-id: 1d983fc37a96277718d34c4a2154d033c6985db8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla signed
module: data
torch.utils.data
release notes: dataloader
release notes category
topic: improvements
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The previous PR #75618 neglected to handle the case where the argument is a tuple/list of DataPipes, as it is the case for
zip
,mux
, etc. This PR addresses that issue.Now the message looks like the following, instead of a bunch of
<...>
inside the tuple.