Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataPipe] Add functional API to StreamReader and FileOpener #76233

Closed
wants to merge 1 commit into from
Closed

[DataPipe] Add functional API to StreamReader and FileOpener #76233

wants to merge 1 commit into from

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented Apr 22, 2022

Per title

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 22, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit fcec2f9 (more details on the Dr. CI page):

Expand to see more

✅ None of the CI failures appear to be your fault 💚

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ejguan ejguan added module: data torch.utils.data release notes: dataloader release notes category topic: improvements topic category labels Apr 22, 2022
@ejguan ejguan requested review from NivekT and VitalyFedyunin April 22, 2022 14:41
@ejguan ejguan force-pushed the add_functional_apis branch from 93c3695 to fcec2f9 Compare April 22, 2022 14:48
NivekT
NivekT approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just small comments about adding to docstrings as well

@ejguan
Copy link
Contributor Author

ejguan commented Apr 22, 2022

@pytorchbot merge this please

facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@ejguan @facebook-github-bot
[DataPipe] Add functional API to StreamReader and FileOpener (#76233)
36d5d51 
Summary:
Per title

Pull Request resolved: #76233
Approved by: https://github.com/NivekT

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b8cce8847f7301a40bcfe8b4de1f0e1b15349e24

Reviewed By: seemethere, osalpekar

Differential Revision: D35874472

Pulled By: ejguan

fbshipit-source-id: ca3d8956951df34f98302d2460385c3061b0940a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NivekT NivekT NivekT approved these changes

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

Assignees
No one assigned
Labels
cla signed module: data torch.utils.data release notes: dataloader release notes category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejguan @facebook-github-bot @NivekT