[DataPipe] Lazily generate exception message for performance #78673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 70fa3e8 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NivekT
added
module: data
[ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@pytorchbot merge -g |
dzdang
added a commit
that referenced
this pull request
Jun 2, 2022
Pull Request resolved: #78673 Approved by: https://github.com/ejguan ghstack-source-id: 24087821ebe7833ece1e8a7b7cb6802e14070dfd
NivekT
added a commit
that referenced
this pull request
Jun 2, 2022
Pull Request resolved: #78673 Approved by: https://github.com/ejguan
This was referenced Jun 2, 2022
atalman
pushed a commit
that referenced
this pull request
Jun 2, 2022
Pull Request resolved: #78673 Approved by: https://github.com/ejguan
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
Summary: Pull Request resolved: #78673 Approved by: https://github.com/ejguan Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/575c42028727db4428dc6bcd03c8631f7798b9d3 Reviewed By: ejguan Differential Revision: D36830075 Pulled By: NivekT fbshipit-source-id: 6bd07a76aa4718364e50b7b9cca4d011067874d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
With this PR, exception message for
IterDataPipeare lazily generated as needed rather than at every call. This greatly improves the performance while iteratingIterDataPipe.I plan to cherry-pick this for 1.12 to prevent performance regression.
Differential Revision: D36830075