Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Could we consider utilizing the index_mapping feature of IntNBitTableBatchedEmbeddingBagsCodegen to enhance the inference performance of QuantManagedCollisionEmbeddingCollection #2669

Open
tiankongdeguiji opened this issue Jan 8, 2025 · 6 comments

Comments

@tiankongdeguiji
Copy link
Contributor

In the current version of _mch_remap within the MCHManagedCollisionModule, the searchsorted method is used for remapping, which may not be the most efficient approach for inference. To enhance the inference performance of the QuantManagedCollisionEmbeddingCollection, could we consider using the index_mapping feature of IntNBitTableBatchedEmbeddingBagsCodegen?

@tiankongdeguiji
Copy link
Contributor Author

hi, @kausv @dstaay-fb @dracifer @sarckk @TroyGarden @PaulZhang12 can you see this problem?

@tiankongdeguiji
Copy link
Contributor Author

Hi, @henrylhtsang @joshuadeng @YLGH can you see this problem?

@iamzainhuda
Copy link
Contributor

Hey, I've relayed this information to a member on our team who wrote this - they should get back to you shortly

@tiankongdeguiji
Copy link
Contributor Author

Hey, I've relayed this information to a member on our team who wrote this - they should get back to you shortly

thx!

@kausv
Copy link
Contributor

kausv commented Jan 13, 2025

@tiankongdeguiji I think that could work.
May be you could write QuantMCHManagedCollisionEmbeddingCollection to try it out?

@tiankongdeguiji
Copy link
Contributor Author

tiankongdeguiji commented Jan 14, 2025

@tiankongdeguiji I think that could work. May be you could write QuantMCHManagedCollisionEmbeddingCollection to try it out?

thx!. The default value of the index_mapping is -1, whereas the default value of the _mch_remap is zch_size. Could you provide some suggestions on how to deal with the difference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants