Add percentage based threshold function and unit tests #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53030312 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53030312 |
Summary: Add percentage based threshold function to mc_modules. Also: 1. Add unit tests for all threshold functions. 2. Add one liner documentation for all threshold functions. 3. Add loggings for threshold. Note that regardless of eviction policy, threshold functions only look at eviction counts. Reviewed By: dstaay-fb Differential Revision: D53030312
henrylhtsang
force-pushed
the
export-D53030312
branch
from
9f38c47 to
6cd1d2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53030312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add percentage based threshold function to mc_modules.
Also:
Note that regardless of eviction policy, threshold functions only look at eviction counts.
Reviewed By: dstaay-fb
Differential Revision: D53030312