Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow automatic extent scaling on line annotations #3761

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Allow automatic extent scaling on line annotations #3761

merged 3 commits into from
Jun 21, 2019

Conversation

poplarShift
Copy link
Collaborator

@poplarShift poplarShift commented Jun 6, 2019 •
edited
Loading

Fixes #3759

The following is now possible:

import holoviews as hv
hv.extension('bokeh')
import numpy as np

hv.VLine(-1).opts(apply_ranges=True, padding=.1) * hv.Scatter(np.random.rand(100,2))

Note that in the matplotlib backend ranges were apparently already applied before then.

philippjfr
philippjfr reviewed Jun 21, 2019
View reviewed changes
holoviews/plotting/bokeh/annotation.py Outdated
@@ -130,6 +130,8 @@ class LineAnnotationPlot(ElementPlot, AnnotationPlot):

style_opts = line_properties + ['level']

apply_ranges = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably be a boolean parameter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, of course.

@poplarShift poplarShift requested a review from philippjfr June 21, 2019 18:07
@philippjfr philippjfr merged commit fd57be8 into master Jun 21, 2019
@philippjfr philippjfr deleted the line_annot_extent branch August 5, 2019 13:54
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout doesn't scale with VLines
2 participants
@poplarShift @philippjfr