-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified redim implementation with convenience methods #1302
Conversation
I've added 10 unit tests of the auxiliary redim method. They are very simple and the core redim method is well tests already. @philippjfr I think this PR is ready for review. I hope to get it merged ASAP as I have some nice improvements to DynamicMap usage that builds on top of this. |
Looks good, I would have considered subclasses that override the |
Agreed. I would definitely split it up into subclasses if the current redim |
Okay sounds good, merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR unifies redim and makes it much more convenient to use, which is especially helpful for DynamicMap declarations. You can now do:
Instead of the more verbose equivalent we have been using till now:
Even for this simplest possible example with only a single kdim, the new style is shorter.
All existing use of redim should act in exactly the same way. What is new are all the redim auxiliary methods that make it easier to pick a particular Dimension parameter to change.
Tasks