Added support for constructing empty Dataset types #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: API
tag: component: data
type: feature
|
Looks good. I would like unit tests for all possible empty constructors though (i.e across data types). |
That's the beauty of Dataset tests, you get a unit test per data type for every one you write. |
|
Great! Happy to merge if you think it is ready and the tests go green. |
|
Ready to merge. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Dataset interfaces except the deprecated NdElement interface now support constructing an empty dataset of the right shape when given an empty list. If you can think of another specification that should also mean empty that would be trivial to add. I think this capability is important when working with streams because often your selection, streamed data or whatever else is empty to begin with and constructing an empty Element can often be a pain.