Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ember-cli-htmlbars to 2.x #53

Closed
jacobq opened this issue Jan 29, 2018 · 2 comments
Closed

Upgrade ember-cli-htmlbars to 2.x #53

jacobq opened this issue Jan 29, 2018 · 2 comments

Comments

@jacobq
Copy link

jacobq commented Jan 29, 2018

The current release (2.1.1) triggers an annoying deprecation warning w/ recent versions of Ember that would be fixed by upgrading to the latest release of ember-cli-htmlbars.

[email protected]
  ├─┬ [email protected]
  │ └── [email protected]

The deprecation warning looks like this and is described here:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   new NPMDependencyVersionChecker (/path/to/project/node_modules/ember-getowner-polyfill/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:33)
@pzuraq
Copy link
Owner

pzuraq commented Jan 30, 2018

started working on the update yesterday and a bunch of things broke 🙃 I'm hoping to get it in and released sometime this week

@pzuraq
Copy link
Owner

pzuraq commented Apr 6, 2018

Closed by #54

@pzuraq pzuraq closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pzuraq @jacobq