Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict super seeding option and consider not using super seeding altogether #12209

Closed
FranciscoPombal opened this issue Mar 20, 2020 · 4 comments

Comments

@FranciscoPombal
Copy link
Member

The very long discussion on #12162 about super seeding led to this: arvidn/libtorrent#4440

Thus, we should

  1. remove the strict super seeding setting from the settings, and
  2. consider not using the non-strict super seeding mechanism at all in the rest of the code base.

I expect point 1 to be more consensual.

@Seeker2
Copy link

Seeker2 commented Mar 20, 2020

I use the non-strict super seeding mechanism on an occasional basis, so I would greatly prefer keeping it.

@ghost
Copy link

ghost commented Mar 21, 2020

Since it’s deprecated now, there’s no point in keeping it.
Some people might still want to use the non strict method. The use case could be when there’s a lot of peers in the swarm with only one seeder with slow upload speed.

@Seeker2
Copy link

Seeker2 commented Mar 21, 2020

Here's another use case:
Is there any way to block a specific client (Thunder)? #10258

@FranciscoPombal
Copy link
Member Author

"Normal" super seeding is decently handled by libtorrent by default. Removal of strict super seeding happening here: #12423

@FranciscoPombal FranciscoPombal removed their assignment Apr 5, 2020
@qbittorrent qbittorrent locked and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants