From 615ad229abd9dd61ae1cf367751fb2756a377b77 Mon Sep 17 00:00:00 2001 From: loderos Date: Tue, 1 Sep 2020 10:48:48 +0200 Subject: [PATCH] Remove host parameter as obligatory in SFTPStorage (#926) * Remove host parameter as obligatory in SFTPStorage This allows the SFTP_STORAGE_HOST setting to actually be used. * Fix tests: make hostname a keyword argument * Fix typo: hostname -> host Co-authored-by: Lode Rosseel --- storages/backends/sftpstorage.py | 4 ++-- tests/test_sftp.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/storages/backends/sftpstorage.py b/storages/backends/sftpstorage.py index 5c4171453..529daf278 100644 --- a/storages/backends/sftpstorage.py +++ b/storages/backends/sftpstorage.py @@ -22,8 +22,8 @@ @deconstructible class SFTPStorage(BaseStorage): - def __init__(self, host=None, **settings): - super().__init__(host=host, **settings) + def __init__(self, **settings): + super().__init__(**settings) self._host = self.host self._params = self.params self._interactive = self.interactive diff --git a/tests/test_sftp.py b/tests/test_sftp.py index dba5fa36c..094c4447f 100644 --- a/tests/test_sftp.py +++ b/tests/test_sftp.py @@ -13,7 +13,7 @@ class SFTPStorageTest(TestCase): def setUp(self): - self.storage = sftpstorage.SFTPStorage('foo') + self.storage = sftpstorage.SFTPStorage(host='foo') def test_init(self): pass @@ -178,7 +178,7 @@ def test_override_init_argument(self): class SFTPStorageFileTest(TestCase): def setUp(self): - self.storage = sftpstorage.SFTPStorage('foo') + self.storage = sftpstorage.SFTPStorage(host='foo') self.file = sftpstorage.SFTPStorageFile('bar', self.storage, 'wb') @patch('storages.backends.sftpstorage.SFTPStorage.sftp', **{