Do not include a BoundingBox tag in WMS responses, when it is null

Update expected test results accordingly
qgis · Oct 6, 2023 · dc5d079 · dc5d079
1 parent beb28f6
commit dc5d079
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/src/server/services/wms/qgswmsrenderer.cpp b/src/server/services/wms/qgswmsrenderer.cpp
@@ -1655,7 +1655,7 @@ namespace QgsWms
       }
     }
 
-    if ( featuresRect )
+    if ( featuresRect && ! featuresRect->isNull() )
     {
       if ( infoFormat == QgsWmsParameters::Format::GML )
       {

diff --git a/tests/testdata/qgis_server/get_postgres_types_json_dict.txt b/tests/testdata/qgis_server/get_postgres_types_json_dict.txt
@@ -3,7 +3,6 @@ Content-Type: text/xml; charset=utf-8
 
 <?xml version="1.0" encoding="UTF-8"?>
 <GetFeatureInfoResponse>
- <BoundingBox maxy="0" maxx="0" miny="0" CRS="EPSG:3857" minx="0"/>
  <Layer name="json">
   <Feature id="2">
    <Attribute value="2" name="pk"/>

diff --git a/tests/testdata/qgis_server/get_postgres_types_json_list.txt b/tests/testdata/qgis_server/get_postgres_types_json_list.txt
@@ -3,7 +3,6 @@ Content-Type: text/xml; charset=utf-8
 
 <?xml version="1.0" encoding="UTF-8"?>
 <GetFeatureInfoResponse>
- <BoundingBox maxy="0" maxx="0" miny="0" CRS="EPSG:3857" minx="0"/>
  <Layer name="json">
   <Feature id="1">
    <Attribute value="1" name="pk"/>
-Original file line number
+Diff line change
@@ Expand Up / @@ -1655,7 +1655,7 @@ namespace QgsWms @@
           }
         }
-        if ( featuresRect )
+        if ( featuresRect && ! featuresRect->isNull() )
         {
           if ( infoFormat == QgsWmsParameters::Format::GML )
           {
@@ Expand Down @@