-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serious regression: whole layer not rendered (when simplify geometry activated) #17960
Comments
Author Name: Giovanni Manghi (@gioman)
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Note: the regression was spotted on a linux (Ubuntu 13.10) machine, not tested on windows yet. |
Author Name: Alvaro Huarte (@ahuarte47) Hi Mathieu, can you test this patch please ? Thanks in avance
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Alvaro, that was fast :) I don't have a build environment ready to test patch :/ can certainly verify when its commited. Looking at your patch code, I should add that I also see the layer-not-rendered issue with polygon layer too. Is the patch covering this case too? If not, I can come up with a simple project to reproduce issue. Glad you can fix this. Beyond the above issue, your 2nd series of simplify geometry commits are having a drastically positive impact. |
Author Name: Jürgen Fischer (@jef-n) Fixed in changeset "8c9f41cfa1e6e8cc6625a3436756e3b29754142c".
|
Author Name: Alvaro Huarte (@ahuarte47)
Hi Mathieu, I think this patch cover this case too. Alvaro |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Alvaro, the first project attached to this issue works much, much better with your patch applied (although I can still make the green dots layer disappear if I zoom out to extreme values). It has however not dealt with disappearing polygon layers (or at least not taken care of all the cases). I've created another test project that shows this quite well: http://www.licadho-cambodia.org/error2.zip (it's >30mb, couldn't attach to this ticket). On my screen, when I open the project, the forest cover polygon layer simply doesn't render. It might show on yours depending on your main canvas size. Zooming in and out a few steps will get the layer to disappear just like with the points example. I'm re-opening this case as further work is needed.
|
Author Name: Alvaro Huarte (@ahuarte47) Hi Mathieu, I have released a new pull request that I hope to be merged soon. Thanks for your tests! |
Author Name: Giovanni Manghi (@gioman) Alvaro Huarte wrote:
Hi Alvaro, i haven't tested the lats patch, but with qgis master just compiled from source I see a strange behaviour when the "simplify on provider side" option is checked, and the vector is a shapefile. On the other hand it works ok with postgis, see attached images. Thanks in advance!
|
Author Name: Alvaro Huarte (@ahuarte47) Hi Giovanni, thanks, I know it, I am conversing with Jürgen Fischer, the commit (#13365a6c77903f1ef9cce012f52ff49c8e35f269a) has the ogr simplification broken Thank you very much |
Author Name: Alvaro Huarte (@ahuarte47) Mathieu Pellerin - nIRV wrote:
Hi Mathieu, I see the layer disappear for scales ~1:1.161.063.094, now the simplification is never applied for point layers and I think that it occurs because of other error. When a layer is rendered, the current map extent is transformed to layer coordinates (using the CRS of the layer), this transformation for so big extreme scales returns empty and any geometry is fetched to be drawed. The error occurs https://github.com/qgis/QGIS/blob/master/src/core/qgsmaprenderer.cpp#L414. I think this error is not caused by my patch, you may please disable simplification and verify the layer disappears? Thank you very much! |
Author Name: Alvaro Huarte (@ahuarte47) Hi Mathieu, @nirvn commented that layers disappears in the extreme zoomed out scales even with simplification disabled. Alvaro |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Alvaro, @nirvn is me :) |
Author Name: Alvaro Huarte (@ahuarte47) Mathieu Pellerin - nIRV wrote:
Argggggggg, sorry, I have not noticed. Alvaro |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) I think we should close it when the polygon layer not rendered issue is fixed (which occurs when simplify geometry is activated). For the other issue that has nothing to do with simplification, I'll file a proper ticket so we can close this one when above problem fixed. |
Author Name: Alvaro Huarte (@ahuarte47) Mathieu Pellerin - nIRV wrote:
ok, I am conversing with Jürgen Fischer about related commit (#13365a6c77903f1ef9cce012f52ff49c8e35f269a) |
Author Name: Jürgen Fischer (@jef-n) Fixed in changeset "12a463d2b06d5f10b94d4143c86465d8c4b0ecad".
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Alvaro, I can still make the polygon layer (shapefile) disappear, as of revision 105ecfa. Disabling simplify geometry prevents layer from disappearing. I'm reopening this blocker.
|
Author Name: Alvaro Huarte (@ahuarte47) Mathieu Pellerin - nIRV wrote:
Hi Mathieu, polygon layer disappear even with simplification disabled. I have tested with QGIS before simplification changes and same behavior. The project uses 'on the fly' transformation (ESPG:3148 -> EPSG:4326), disabling this transformation the layer appears. Can you confirm it please ? Thanks! |
Author Name: Giovanni Manghi (@gioman) Mathieu Pellerin - nIRV wrote:
just tested the same revision with the provided project/polygon layer and there are no issues here. |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Alvaro, the layer gone missing is definitively linked to on the fly reprojection between ESPG:3148 (meter-based) to EPSG:4326 (degree-based); that said, on three linux machines I tested, when simplification is disabled, the polygon layer never disappears. The three machines all run Ubuntu 13.10 and uses the QGIS master packages offered @ qgis.org/debian-nightly. Those packages are compiled with:
Giovanni, tested using which QGIS version / master build? Windows or linux? As I said, I can reproduce all the time on three linux machines. |
Author Name: Alvaro Huarte (@ahuarte47) Hi Mathieu, to try reproduce the error, please can you send me the situation on the map? (windows size, map center point, and map scale) and as the simbology of the layer is defined. Thanks in advance |
Author Name: ramon . (ramon .) Mathieu seems to think I can get the error with this data http://www.licadho-cambodia.org/error2.zip. What I'm seeing is that when the data complexity changes in a hurry the entire canvas goes blank for bit while the rendering catches up with the zooming. The most reliable why I can do it is to zoom in to a reasonably complex bit, say 105.66267 13.48494 at say 1:10000. Then zoom out quickly - mouse wheel it. I'm not sure this will help, but I'd describe the symtoms a bit differetly than above, so maybe it will. |
Author Name: Alvaro Huarte (@ahuarte47) Thanks Ramon, I can reproduce this behavior in QGIS 2.0 Dufour and master before simplification was merged. When user changes the visibility of layer while it is being rendered and repeatedly user changes the zoom with mouse wheel, then the layer disappears or it is rendered even with visibility disabled. I had already seen before simplification was merged. Can you confirm it please ? Note: |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) I've recorded a video of the issue, which hopefully might do a better job than my words at explaining the problem; it's here: http://licadho-cambodia.org/bug.webm (10mb) Towards the end of the short clip, you'll clearly see that every time I activate simplify geometry, the layer goes missing, and vise versa. I can reproduce super easily at scale 1:1,597,047 and 1:940,642 (and a bunch of other scales) |
Author Name: Alvaro Huarte (@ahuarte47) Ok Mathieu, thanks, I study it! |
Author Name: Alvaro Huarte (@ahuarte47) I am sorry Mathieu, I do not get to reproduce this behavior. I use Windows, I will have to setup a VM with Ubuntu 13.10 (Arggghhh! ;-)) |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Alvaro, the log window doesn't throw any error message. Yes, please, try on linux / ubuntu 13.10, it does seem to be part of the "recipe" to get to this issue. Which could mean the bug is triggered by a different version of the underlying libraries QGIS make use of, or display driver (my three machines have NVIDIA video cards). |
Author Name: Alvaro Huarte (@ahuarte47) Ok Mathieu, I'll try, but it will be hard for me, I've never used Linux, much less compiled QGIS in Linux |
Author Name: Giovanni Manghi (@gioman) Mathieu Pellerin - nIRV wrote:
Hi all, I use ubuntu 12.04 (intel video card), qgis master from nightly build repo + ubuntugis (gdal 1.10), simplification active, and I can't replicate the described issue (even trying very hard) with the attached sample project/layer. |
Author Name: ramon . (ramon .) Still not sure if its the same bug, but tracks.zip file is giving this error on the mint terminal at home: ERROR 1: IllegalArgumentException: point array must contain 0 or >1 elements Would say it's something to do with odd geometries from a gps track - except that I had it in a different workspace today where it worked fine. |
Author Name: Alvaro Huarte (@ahuarte47) ramon . wrote:
I have not yet tested the data, but this commit (ahuarte47@2baf403) fixes an error in QgsGeometry class throwing this message |
Author Name: Alvaro Huarte (@ahuarte47) Hi Mathieu, I successfully built QGIS master in Ubuntu 13.10 :-) !Ubuntu1310_Issue9360.jpg! I use VirtualBox in Windows XP 32bits. But I can't replicate the described issue (shapefile from error2.zip) :-(
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Alvaro, the builds I use on my three machines with which I can replicate all the time are builds offered via the qgis debian-nightly ppa. Can you try to install those and check whether issue happen? If it's not happening then, I give up :/ On the positive side of things, glad this got you to increase knowledge on compiling under Linux :) |
Author Name: Giovanni Manghi (@gioman) Mathieu Pellerin - nIRV wrote:
I have also tested extensively qgis master installed on ubuntu via ubuntugis, self compiled and on windows/osgeo4w and I cannot replicate the issue with the provided test project/data. I will close this ticket for now, we need to clean the blockers queue before the new release. If you find the issue to be not a local issue (as it probably is) please reopen this ticket.
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Giovanni, seems closing this issue is right thing to do considering I appear to be the only one able to reproduce. Will continue investigating cause of issue and re open if/when I figure this out. Have you tried it on a build that relies on saucy system packages? (Ie not with the ubuntugis packages) |
Author Name: Giovanni Manghi (@gioman)
no, I tested only on precise machines, |
Author Name: Alvaro Huarte (@ahuarte47) Mathieu Pellerin - nIRV wrote:
Hi Mathieu, I can replicate this issue in my Virtual Box with Ubuntu 13.10 + qgis debian-nightly package. But I have no idea how to debug this, source code, IDE to use ... sorry. I am newbie in Ubuntu, I do not even know where to begin. I will try to locate information. Already checked that Ubuntu 13.10 + QGIS master works fine. Best regards |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Alvaro, am I right in understanding that:
I'm relieved we got to a point where others can replicate the issue. |
Author Name: Alvaro Huarte (@ahuarte47) Mathieu Pellerin - nIRV wrote:
You are right, but I do not know how to solve it. I guess I should use QtCreator or Eclipse-CDT to build QGIS, but where is the source code for 'http://qgis.org/debian-nightly' repository ? |
Author Name: Jürgen Fischer (@jef-n) Alvaro Huarte wrote:
You can use @apt-get source@ to get the sources. But that's the same a in our repository. Did you build packages? That should already give you the same configuration. |
Author Name: Alvaro Huarte (@ahuarte47) Jürgen Fischer wrote:
Yes I built GQIS+master using the guide, it works fine. Then, why 'debian-nightly' not work? |
Author Name: Jürgen Fischer (@jef-n) Alvaro Huarte wrote:
The guide describes multiple paths. Just to be sure: You used "3.8. Building Debian packages":http://htmlpreview.github.io/?http://github.com/qgis/QGIS/blob/master/doc/INSTALL.html#toc11 (that you ran into the @libpython2.7.so@ problem suggests that you didn't). Does the about screen in the nightly build match the output of yours? |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) I've just upgraded by system to ubuntu's upcoming trusty 14.04 system. The debian-nightly packages are still affected by the regression. However, if I manually compile QGIS from the same source tree, the regression is gone. Same packages, same source revision. I'm lost here. Jef, could it be a compiler version or setting issue? |
Author Name: Jürgen Fischer (@jef-n) Mathieu Pellerin - nIRV wrote:
Did you build packages or did you manually configure cmake?
I don't know either. Can you compare http://dash.orfeo-toolbox.org/buildSummary.php?buildid=139988 and/or http://dash.orfeo-toolbox.org/buildSummary.php?buildid=139984 with the output of your build? I suppose there are differences. As the logs don't show all versions, you could also compare the about boxes' content. |
Author Name: Alvaro Huarte (@ahuarte47) Jürgen Fischer wrote:
Hi, sorry no answer, these days I'm finding it impossible to look for family reasons. I built QGIS in Ubuntu 13.10 using ccmake as described in http://htmlpreview.github.io/?http://github.com/qgis/QGIS/blob/master/doc/INSTALL.html#toc10. It works fine. But installing debian-nightly packages as described in http://www.qgis.org/en/site/forusers/alldownloads.html, it works wrong. The about dialog using debian-nightly packages (Apparently are equal): !Ubuntu_13.10-debian-nightly.png! When I built QGIS using ccmake, I configured libpython2.7.so as described in Nyall in http://nyalldawson.net/2013/04/building-qgis-on-ubuntu-13-04/ ... 'Update: a better solution is to change the PYTHON_LIBRARY option from /usr/lib/libpython2.7.so to /usr/lib/x86_64-linux-gnu/libpython2.7.so'
|
Author Name: Giovanni Manghi (@gioman) Jürgen Fischer wrote:
it is weird because I use the nightly build repos on Ubuntu 12.04 (mint actually) and I can't replicate the issue. Should we reopen this? if it is confirmed by others using the official packages this could be a problem in the upcoming new release. |
Author Name: Alvaro Huarte (@ahuarte47) Hi, sorry, these days I'm finding it impossible to look this issue for family reasons. |
Author Name: Alvaro Huarte (@ahuarte47) Hi, I have released a new pull request that attempts to correct this issue or as least show debug information: I have not test it for Ubuntu 'debian-nightly packages' but the I think the clues given by Gavin focus error to the point that I modified Best Regards |
Author Name: Martin Dobias (@wonder-sk)
|
Author Name: Martin Dobias (@wonder-sk) Fixed in changeset "5d4cf3086abe6bb205423771093cc5eebac6d5b8".
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) !! Yay !! Martin, out of purely geeky curiosity, why was this not showing on self-compiled builds and showing on the debian-nightly packages? |
Author Name: Martin Dobias (@wonder-sk) Actually, I have replicated the problem by chance while playing with #17707 on my self-compiled build (not using debian-nightly at all). I don't know how much the debian-nightly packages differ from your own build, but it could be compiler version or maybe some compiler flags... This is kind of a random bug that waits in the dark corner and usually strikes just after the release :-) |
Author Name: Alvaro Huarte (@ahuarte47) Martin Dobias wrote:
ufff, Thank you very much Martin, this type of error I would not have ever found! |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)
Original Redmine Issue: 9360
Affected QGIS version: master
Redmine category:vectors
Assignee: Martin Dobias
A very serious regression has made its way into QGIS master following the (2nd) simplify geometry commits. Whole layers end up not rendering when zooming in / out.
Steps to reproduce:
Disabling [ ] simplify geometry option fixes the serious regression.
The text was updated successfully, but these errors were encountered: