QgsRectangle isEmpty documentation doesn't match implementation #45563
Assignees
Labels
Bug
Either a bug report, or a bug fix. Let's hope for the latter!
Comments
This was referenced Feb 16, 2022
|
PR aimed at fixing this bug is #47404 |
strk
added a commit
to strk/QGIS
that referenced
this issue
Oct 14, 2023
Make sure a Null rectangle is always also considered Empty. Print Null rectangle as Null, still print details of Empty rectangles. Update expected QgsRectangle::toString output on Null rectangle Closes qgisGH-45563
strk
added a commit
to strk/QGIS
that referenced
this issue
Oct 16, 2023
Make sure a Null rectangle is always also considered Empty. Print Null rectangle as Null, still print details of Empty rectangles. Update expected QgsRectangle::toString output on Null rectangle Closes qgisGH-45563
strk
added a commit
to strk/QGIS
that referenced
this issue
Oct 17, 2023
Make sure a Null rectangle is always also considered Empty. Print Null rectangle as Null, still print details of Empty rectangles. Update expected QgsRectangle::toString output on Null rectangle Closes qgisGH-45563
strk
added a commit
to strk/QGIS
that referenced
this issue
Oct 17, 2023
Make sure a Null rectangle is always also considered Empty. Print Null rectangle as Null, still print details of Empty rectangles. Update expected QgsRectangle::toString output on Null rectangle Closes qgisGH-45563
strk
added a commit
to strk/QGIS
that referenced
this issue
Oct 18, 2023
Make sure a Null rectangle is always also considered Empty. Print Null rectangle as Null, still print details of Empty rectangles. Update expected QgsRectangle::toString output on Null rectangle Closes qgisGH-45563
strk
added a commit
to strk/QGIS
that referenced
this issue
Oct 19, 2023
Make sure a Null rectangle is always also considered Empty. Print Null rectangle as Null, still print details of Empty rectangles. Update expected QgsRectangle::toString output on Null rectangle Closes qgisGH-45563
strk
added a commit
to strk/QGIS
that referenced
this issue
Oct 20, 2023
Make sure a Null rectangle is always also considered Empty. Print Null rectangle as Null, still print details of Empty rectangles. Update expected QgsRectangle::toString output on Null rectangle Closes qgisGH-45563
strk
added a commit
to strk/QGIS
that referenced
this issue
Oct 22, 2023
Construct a proper null rectangle by default. Make sure a Null rectangle is always also considered Empty. Print Null rectangle as Null, still print details of Empty rectangles. Update expected QgsRectangle::toString output on Null rectangle Includes unit tests Closes qgisGH-45563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the bug or the crash?
According to method documentation for QgsRectangle class "An empty rectangle may still be non-null if it contains valid information (e.g. bounding box of a point)" but the bounding box of
POINT(0 0)is found to be also NullSteps to reproduce the issue
QgsRectangle r1( 0, 0, 0, 0 );
QVERIFY( ! r1.isNull() ); // fails
QVERIFY( r1.isEmpty() );
Versions
master
Supported QGIS version
New profile
Additional context
No response
The text was updated successfully, but these errors were encountered: