-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTR: fails to build with SIP 6.8.0 #55481
Comments
|
until qgis/QGIS#55481 is fixed
@buzo-ffm I've dropped a patch at https://aur.archlinux.org/packages/qgis-ltr#comment-946413 |
I have encountered the same issue with 3.34.1 |
That patch is about pdal 2.6.0 which already fixed on master branch, but It has nothing to do with this issue. |
Is this actually a qgis issue? The error looks like a bug within sip. Are there other packages that use that version of sip in arch? |
Well this issue is due a typo is sip code https://www.riverbankcomputing.com/pipermail/pyqt/2023-November/045607.html |
I don't understand why, if this bug was fixed in sip on 30 November there isn't 6.8.1 or 6.8.0.1 release with the fix. I just wrote to riverbank asking if I have failed to find a point release that does have the fix. EDIT: upstream is trying to make sure all problems are resolved before issuing a point release. |
The 6.8.0 was defective and caused many, if not almost all, uses of sip to break. E.g. qgis/QGIS#55481 Cherry-pick upstream change from 30 November, because for reasons I do not understand there isn't a fixed point release. Add a note that updates should be build tested with qgis, as upstream's QA is clearly not good enough to assume that will be ok.
I have been in touch with sip upstream, reporting problems and testing. There are commits to sip's 6.8-maint branch since 6.8.1, and I just tested with qgis now gets much further along, and fails with
|
instead of the generic QgsException one Refs warning in qgis#55481 (comment) ``` /tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38168: warning: exception of type 'QgsProviderConnectionException' will be caught 38168 | catch (QgsProviderConnectionException &sipExceptionRef) | /tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38158: warning: by earlier handler for 'QgsException' 38158 | catch (QgsException &sipExceptionRef) ```
instead of the generic QgsException one Refs warning in #55481 (comment) ``` /tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38168: warning: exception of type 'QgsProviderConnectionException' will be caught 38168 | catch (QgsProviderConnectionException &sipExceptionRef) | /tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38158: warning: by earlier handler for 'QgsException' 38158 | catch (QgsException &sipExceptionRef) ```
instead of the generic QgsException one Refs warning in #55481 (comment) ``` /tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38168: warning: exception of type 'QgsProviderConnectionException' will be caught 38168 | catch (QgsProviderConnectionException &sipExceptionRef) | /tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38158: warning: by earlier handler for 'QgsException' 38158 | catch (QgsException &sipExceptionRef) ```
I have been working with upstream and just built/installed sip from the tip of the 6.8-maint branch, and with that built qgis 3.23.13. I had a successful build and the resulting installation worked to open a project with geopackage vector data and a TMS baselayer. Also, the file that threw the error above now diffs equal, except for @buzo-ffm Can you edit the title to stay "6.8.0" rather than "6.8", or perhaps after someone confirms 6.8.1 say "fails to build with 6.8.0 (6.8.1 is ok)" as a hint to people searching? |
For archlinux users, I have reported the sip error here : Editing |
instead of the generic QgsException one Refs warning in #55481 (comment) ``` /tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38168: warning: exception of type 'QgsProviderConnectionException' will be caught 38168 | catch (QgsProviderConnectionException &sipExceptionRef) | /tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38158: warning: by earlier handler for 'QgsException' 38158 | catch (QgsException &sipExceptionRef) ```
That's one bug, but there are more; I count 9 fixes in upstream hg. Fixing SocStringSignature lets the build get a lot further, but it failed on something else. For now, reverting to 6.7.12 seems like the right approach. |
qgis 3.34.1 still failing with sip 6.8.1 |
Could you please post the error? |
Sorry, It wasn't using sip 6.8.1. I will retry with it. |
6.8.0 fails with qtwebkit enable, without qtwebkit it builds fine. |
I just built with 6.8.1, NetBSD 10 amd64. No surprise as I had just built with the same bits pre-tag debugging with upstream. |
sip 6.8.1
|
@MehdiChinoune Did you confirm that with only changing sip to 6.7.12 or some such version, it builds? I'm not suggesting it didn't -- 6.8 rewrites the generation code in python, and therefore unicode encoding issues are not that surprising :-( |
Latest successful build was qgis-3.34.0+sip-6.7.12 |
There is now a commit on 6.8-maint beyond 6.8.1 which probably fixes your issue. See sip upstream repo:
|
It works. |
Shouldn't this issue be closed, after sip got fixed? |
What is the bug or the crash?
LTR 3.28.13 fails to build on Arch Linux with SIP 6.8, see attached build output.
Steps to reproduce the issue
Try to build LTR 3.28.13 with SIP 6.8.
Versions
QGIS LTR 3.28.13, SIP 6.8
Supported QGIS version
New profile
Additional context
No response
The text was updated successfully, but these errors were encountered: