QGIS Server OGC: Display name is not provided in GetFeatureInfo json/gml response

[MarcelGeo]

What is the bug or the crash?

If the WITH_DISPLAY_NAME parameter is included in a WMS GetFeatureInfo request, the display name is omitted from the response GeoJSON or WFS GML format. It would be included as attribute with ... name in properties object for each feature.

The displayName field is included in the text/xml response format, but the XML structure is not standardized and harder to parse with standard FE libraries (openlayers ... ).

Example of responses for GET service=WMS&request=GetFeatureInfo&INFO_FORMAT=application/json&WITH_DISPLAY_NAME=true

json 👎 no display name :

{
  "features": [
    {
      "geometry": {
        "coordinates": [-111, 111],
        "type": "Point"
      },
      "id": "closure_df66a4aa_cf33_497e_b134_aa157ea885df.339",
      "properties": {
        "ID": 106,
      },
      "type": "Feature"
    }]
}

text/xml 👍

<GetFeatureInfoResponse>
 <Layer name="closure_df66a4aa_cf33_497e_b134_aa157ea885df">
  <Feature id="339">
   <Data>
    <Attribute name="ID" value="106"/>
   </Data>
   <Attribute name="displayName" value="Item 339"/>
   <BoundingBox CRS="EPSG:3857" minx="-111" miny="111" maxy="6803278.84325854" maxx="-111"/>
   <Attribute type="derived" name="geometry" value="Point (-111 111)"/>
  </Feature>
 </Layer>
</GetFeatureInfoResponse>

Note: coordinates are just examples

Steps to reproduce the issue

1. GO to layer properties
2. GO to Display
3. Enable display name attribute
4. Make GetFeatureInfo request to this project with WITH_DISPLAY_NAME parameter (as documented here https://docs.qgis.org/3.34/en/docs/server_manual/services/wms.html#wms-withdisplayname)

Versions

3.34.12-Prizren

Supported QGIS version

• I'm running a supported QGIS version according to the roadmap.

New profile

• I tried with a new QGIS profile

Additional context

No response

[elpaso]

@Gustry is this a bug or a feature request?

[Gustry]

Oups, I didn't take take of other formats indeed. I would say it's a bug, as indeed, formats should be traited "equivalent" from each other and to have the same features when possible. Sorry for that.

Original PR : #52251

[elpaso]

Oups, I didn't take take of other formats indeed. I would say it's a bug, as indeed, formats should be traited "equivalent" from each other and to have the same features when possible. Sorry for that.

Original PR : #52251

Thanks for clarifying, do you have time to fix it or should I ?

[Gustry]

Sorry, I'm not building QGIS since a few months, so it makes coding in CPP a bit tricky. If you want to take it, you can.

[elpaso]

I guess we can limit that to json: GML has a schema.

[MarcelGeo]

I guess we can limit that to json: GML has a schema.

yeah, json is enough, thanks