Test and fix QgsRectangle::isNull

[strk]

Adds tests for QgsRectangle::isNull, improve toString to show the difference between Null and Empty, eventually fix the 0,0,0, rectangle case to still be Empty and NOT Null (to match documentation)

[nyalldawson]

I'm wondering if it's cleaner to just set these all as nan, and adjust the isnull test accordingly. What's your thoughts?

[strk]

I don't think it matters, as long as callers all check for isNull

[nyalldawson]

I think this is heading in the right direction, nice work @strk !

[strk]

There are 15 failing tests. One of them (testClipRasterByExtent) reports:

Running alg: "gdal:roughness"
Algorithm parameters are {'BAND': 1, 'COMPUTE_EDGES': False, 'INPUT': 'dem_tif_71fcbde4_c812_4dde_bce3_37bf5d741c31', 'OPTIONS': ''n 0.0 0.0 0.0 0.0 -of JPEG /root/QGIS/python/plugins/processing/tests/testdata/dem.tif /tmp/tmp1cjivwli/check.jpg'

  ['gdal_translate',
+  '-projwin 0.0 0.0 0.0 0.0 -of JPEG '
-  '-projwin 1.7976931348623157e+308 -1.7976931348623157e+308 '
-  '-1.7976931348623157e+308 1.7976931348623157e+308 -of JPEG '
   '/root/QGIS/python/plugins/processing/tests/testdata/dem.tif '
   '/tmp/tmp1cjivwli/check.jpg']

I would think -projwin should NOT be passed at all, so the expected result is wrong to me (expects to pass an invalid projwin when the rect is null, am I reading it right ?

The test is in python/plugins/processing/tests/GdalAlgorithmsRasterTest.py

[strk]

That gdal_translate test is very suspiciou, because it expects gdal_translate being invoked with a -projwin 0.0 0.0 0.0 0.0 parameter but it passes the algorithm an EXTENT value of QgsRectangle(1, 2, 3, 4), so I don't know why it should end up being 0.0.0.0. @m-kuhn the test is documented to be yours. Ideas ?

[m-kuhn]

Phew, that must be from years ago, do you have a link to the code or the PR that added it?

[strk]

Phew, that must be from years ago, do you have a link to the code or the PR that added it?

Nope, and the testsuite had a reorganization at some point (2019) which makes it harder to tell.
The question is: does it make sense for -projwin to be 0,0,0,0 when the given extent is Null ? I'd think either NO -projwin should be given OR an error should be thrown (if the argument is mandatory)

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

[strk]

Reopening as bug #45563 which this PR attempts to address, is still existing

[strk]

Reopening this PR didn't work, so I'm creating a new one replacing this

[strk]

Superceeded by #47404