qgswfsgetcapabilities: Restore previous empty bounding box behavior #55927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
reviewed
Jan 23, 2024
According to the WFS 1.1.0 specs "The <WGS84BoundingBox> element is used to indicate the edges of an enclosing rectangle in decimal degrees of latitude and longitude in WGS84" but the expected behavior is not specified when the data are empty. Up to QGIS 3.32, QGIS server returned: ``` <ows:WGS84BoundingBox dimensions="2"> <ows:LowerCorner>0 0</ows:LowerCorner> <ows:UpperCorner>0 0</ows:UpperCorner> ``` However, as a side effect of a change in `QGSRectangle` (see: qgis#54646), QGIS server now returns since the 3.34 version: ``` <ows:WGS84BoundingBox dimensions="2"> <ows:LowerCorner>inf inf</ows:LowerCorner> <ows:UpperCorner>-inf -inf</ows:UpperCorner> ``` This changes restores the QGIS 3.32 behavior.
ptitjano
force-pushed
the
wfs-empty-bounding-box
branch
from
97e9a43 to
63413f8
Compare
Done |
troopa81
approved these changes
Jan 23, 2024
lbartoletti
added
backport release-3_34
and removed
backport queued_ltr_backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the WFS 1.1.0 specs "The element is used to indicate the edges of an enclosing rectangle in decimal degrees of latitude and longitude in WGS84" but the expected behavior is not specified when the data are empty.
Up to QGIS 3.32, QGIS server returned:
However, as a side effect of a change in
QGSRectangle(see: #54646), QGIS server now returns since the 3.34 version:This changes restores the QGIS 3.32 behavior.
cc @troopa81