-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum natural gradient #35
Comments
There is a plan to have a function that calculates the Here is an old issue on The QFIM is essentially the metric tensor needed for the natural gradient. What would be the best way to integrate these two ideas? Because that would introduce a circular dependency between |
In general, an abstract interface for obtaining gradients from a backend (if provided) should be present in Qibo, since the But no implementation for the gradient extraction should be supported by Qibo backends' themselves, while they should be in those present here. A higher level interface for accessing gradients may be provided in here, but it should not prevent to access the same information from the bare gradient, and reconstructing the same function somewhere else. If instead you want to use the PSR or something else to compute a gradient while that is not natively provided, then functions using this feature should be split out of the main |
This strict rule will create issues, e.g. qiboteam/qibo#1485. Now what happens when gradient descent is for tomography (or any other quantum info application in the present or future) and not for some variational model? I do not have a solution to this problem, but contradictions will inevitably happen (e.g. the QFIM function I mentioned and this new PR opened). As I mentioned to @stavros11 in person, my first idea to implement the QFIM function was to implement an |
That's exactly what I said above...
This would be
This is the The only additional part is that will only get native gradients, while others may be available. So, if you use the |
After closing the dedicated PR in Qibo, this issue exists as a reminder natural gradient is a feature we want to support in the future.
The text was updated successfully, but these errors were encountered: