Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci is failing in mypy checks #1309

Closed
woodsp-ibm opened this issue Jan 24, 2024 · 0 comments · Fixed by #1310
Closed

Ci is failing in mypy checks #1309

woodsp-ibm opened this issue Jan 24, 2024 · 0 comments · Fixed by #1310

Comments

@woodsp-ibm
Copy link
Member

Nighlty CI is failing as follows

Error: qiskit_nature/second_q/hamiltonians/lattices/lattice.py:25: error: Unused "type: ignore" comment  [unused-ignore]
Error: qiskit_nature/second_q/hamiltonians/lattices/hexagonal_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_triangular_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_square_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_line_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_lattice.py:20: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_kagome_lattice.py:18: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_hyper_cubic_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_hexagonal_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/test_ising_model.py:19: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/test_heisenberg_model.py:16: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/test_fermi_hubbard_model.py:18: error: Unused "type: ignore" comment  [unused-ignore]

which seems attributable to yesterdays (23 Jan) release of a new rustworkx version. The prior run that passed was on 0.13.2 and the new version is 0.14.0

This is a new feature release of Rustworkx that adds many new features to the library. The highlights of this release are:

   * Fully type annotated for support with [mypy](https://mypy-lang.org/) and other tooling

so presumably with the annotation the ignore is now in conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant