Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate all LegacyDriver related code #561

Closed
mrossinek opened this issue Feb 15, 2022 · 0 comments · Fixed by #578
Closed

Deprecate all LegacyDriver related code #561

mrossinek opened this issue Feb 15, 2022 · 0 comments · Fixed by #578
Assignees

Comments

@mrossinek
Copy link
Member

What is the expected enhancement?

The legacy driver results, QMolecule and WatsonHamiltonian, have been deprecated in Qiskit Nature 0.2.0.
We currently still have various places where we use them via their public API in order to provide migration/conversion utilities. Most notably in the HDF5Driver (as pointed out here) and in the property framework via the .from_legacy_driver_result conversion methods.

In order to be able to actually remove these legacy driver results, we must first deprecate all methods which use them in their public API. Ideally, we add these deprecations as part of 0.4.0
Once that is done, we should be able to fully remove these classes from the public API in 0.5.0 (we can still provide a conversion utility in the HDF5Driver for example, it would just be a private method instead of being part of the public, user-facing API).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants