Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate legacy code #749

Closed
mrossinek opened this issue Jul 19, 2022 · 0 comments · Fixed by #761
Closed

refactor: deprecate legacy code #749

mrossinek opened this issue Jul 19, 2022 · 0 comments · Fixed by #761
Assignees

Comments

@mrossinek
Copy link
Member

mrossinek commented Jul 19, 2022

What is the expected enhancement?

#746 migrated (almost) the entire code base into a new structure.
While doing so, we did not yet add deprecation warnings for the legacy code. This issue can be closed, once all legacy modules have deprecation warnings associated with them.

Some caveats:

  • the BOPESSampler-related code has not been migrated. However, it should still be deprecated. A feature request will be opened shortly explaining how we may achieve warm-starting variational algorithms in the future. This will be the de-facto replacement of the BOPESSampler. (EDIT: link to said issue Warm-Starting InitialPoint #750)
  • the protein folding code has also not been migrated. Extract the Protein Folding Code #742 reflects that this code will indeed be extracted into another repository in its entirety. Maybe we should hold off with the deprecation warnings on that particular code, until the extraction has been done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants