Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI not producing any return codes #27

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Fix CLI not producing any return codes #27

merged 1 commit into from
Sep 14, 2020

Conversation

fauxpark
Copy link
Member

The return code provided by milc.cli() is discarded. This adds the same logic as in https://github.com/qmk/qmk_firmware/blob/6499eb6a3c512ded96443649d66274ce1064df0f/bin/qmk#L81-L93 to exit the CLI with the proper return code.

@fauxpark fauxpark added the bug Something isn't working label Sep 14, 2020
@fauxpark fauxpark requested review from skullydazed and a team September 14, 2020 05:09
@skullydazed skullydazed merged commit 8a531f7 into qmk:master Sep 14, 2020
@skullydazed
Copy link
Member

Thanks!

@fauxpark fauxpark deleted the fix-return-codes branch September 14, 2020 15:32
@fauxpark fauxpark mentioned this pull request Sep 15, 2020
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @skullydazed