[TADA68 ISO] Fails to generate working binary

[DarkDefender]

Hi, I tried out the configurator and generated the following keymap for my tada68:
conf.zip

At first it didn't want to compile (failed at the "Running" step), so I exported the keymap and loaded it again. After that, it seems like the compile goes through without any errors and I get a 4kb .bin file.

However it doesn't work at all when I flash my tada68 with it. I don't know what the problem could be as I do not see any error output from the configurator. If I click "dowload source" i get:

{"message":"Compile job not finished or other error."}

[yanfali]

Hi @DarkDefender the tada68 support is still incomplete unfortunately. @skullydazed is working on it and I hope to have a solution for you presently. I'll update this issue once we've figured it out.

[DarkDefender]

Ah, I see. No problem, I took and compiled my own .bin file from source. So I'm in no hurry really.

[skullydazed]

This should be fixed once we deploy qmk/qmk_api#28. Typically we deploy the same day or next day after merging.

[yanfali]

@DarkDefender can you give it another go please? We just added .bin support. You will be our first user.

[DarkDefender]

Oh, I see. I think I will have some time tomorrow when I can test it out. Thanks for the heads up

[yanfali]

@DarkDefender currently it's only deployed to a test instance. We were looking for a confirmation before adding it to the main config.qmk.fm site. You can test it at https://yanfali.github.io/qmk_configurator/#/tada68/LAYOUT_iso

[DarkDefender]

Using the same json file as before, it now generates working binaries. However there is one huge flaw. The middle row is shifted to the left. So "asdf" -> "sdfg".

I don't know where to find the generated .c file. However this is my working config file that I used when I build the firmware myself: https://gist.github.com/DarkDefender/d4274023bec1e02e8618d384c53340d7

[yanfali]

Try download source. It'll contain the keymap.

[DarkDefender]

Oh right, I did download the source before. But I didn't expect it to create a new layout in the ordinary place somehow...

So here is the generated source (edited for formatting):
https://gist.github.com/DarkDefender/eee9cfc8e57059bb804fbd9ee143e788

If we compare it to my working config, we can see that the backslash/iso hash key is in the wrong place. While it would be logical to have it in its actual physical location, it seems like it should be in the same place as the ansi backslash key (which is somewhat logical as it will act as the ansi key if you switch to a ansi keyboard keymap).

It also explains the shift to the left.

[yanfali]

Thanks for looking into this. It sounds like the layout is wrong in the main repo. I'll chat with the firmware folks and try and get this fixed up.

[DarkDefender]

I did base my config on one of the available iso configs in the main repo btw (iso-uk).

[yanfali]

OK. Looks like this is a firmware issue. Going to close this now as fixed.

qmk/qmk_firmware#3943 to follow thread on there @DarkDefender

[yanfali]

@fcoury also tested the bin support on an ANSI Tada and it worked fine. Thanks @fcoury

[fcoury]

Thank you all for the amazing and continued work @yanfali