Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize KPrepublic keyboards into the same folder #12155

Closed
peepeetee opened this issue Mar 8, 2021 · 4 comments
Closed

Organize KPrepublic keyboards into the same folder #12155

peepeetee opened this issue Mar 8, 2021 · 4 comments
Labels
help wanted question stale Issues or pull requests that have become inactive without resolution.

Comments

@peepeetee
Copy link
Contributor

peepeetee commented Mar 8, 2021

I would like to organize KPrepublic keyboards into the same folder, what steps should I take?

@peepeetee
Copy link
Contributor Author

peepeetee commented Mar 8, 2021

List of keyboards(not sure if comprehensive, please check):

daisy
staryu
cospad
bm16a
bm16s
bm40hsrgb
bm43a
bm60poker (manufacturer listed as KP Republic rather than KPrepublic, consider standardizing?)
bm60rgb (manufacturer listed as KP Republic rather than KPrepublic, consider standardizing?)
bm60rgb_iso
bm68rgb
dz60
jj4x4
jj40
jj50
xd002
xd004
xd60
xd68
xd75
xd84
xd87 (manufacturer listed as KP Republic rather than KPrepublic, consider standardizing?)
xd84pro
xd96

@ridingqwerty
Copy link
Contributor

Just reiterating some thoughts from Discord and adding some others not yet stated there:

  • Pinging the "owner" of each board/keymap is considered the polite thing to do when making changes, but in this case I want to say most of these were ported in by the community rather than submitted directly by KPRepublic. Worth checking them out, I have only spot checked a few. If it was ported by a QMK Collaborator I would say it wouldn't really be worth pinging the submitter as we will see the PR.

  • Structurally, the naive aspect of this PR is going to moving each keyboards/<keyboard>/* path into a vendor folder keyboards/kprepublic/<keyboard>/*, but may also involve updating readme info so that flashing instructions refer to this new path.

  • dz60 appears to in fact be a kbdfans board, and there may be others that aren't actually KPRepublic in your list.

  • I am personally unsure if it's the case that a board made by an independent creator would have their hardware sold by KPRepublic in a strict vendor relationship where KPR doesn't actually own whatever rights to the board.

  • Consider submitting this to the develop branch. Also note this will be considered a breaking change so it cannot be merged until the next breaking change submission.

@stale
Copy link

stale bot commented Jun 6, 2021

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 6, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.

@stale stale bot closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted question stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

No branches or pull requests

2 participants