Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Keyboards & Keymaps into submodule #16346

Closed
ThePreviousOne opened this issue Feb 13, 2022 · 5 comments
Closed

Move Keyboards & Keymaps into submodule #16346

ThePreviousOne opened this issue Feb 13, 2022 · 5 comments
Labels
help wanted question stale Issues or pull requests that have become inactive without resolution.

Comments

@ThePreviousOne
Copy link
Contributor

I'm sure this has been brought up before but I can't find the issue.
Keyboards and keymaps are not part of the firmware. Personally I use the commit history to determine if I need to update my local branch or not, but the majority of commits are either new keyboards & keymaps or documentation changes. I won't advocate moving documentation as thats really just extra work with little benefit considering that documentation changes can be important when there is a new feature added, but the same is not true of keyboards or keymaps.

The commit history is the closest thing we have to a change log, which is important in a project this big to keep track of new features.
I realize maintaining an actual change log is extra work and I wouldn't ask anyone to do it, never the less it is important to have one in some form.

@filterpaper
Copy link
Contributor

There are changes proposed in #11269 to support out-of-tree userspace.

@drashna
Copy link
Member

drashna commented Mar 10, 2022

This is a topic that comes up frequently enough.

The biggest issue here isn't just moving stuff, it's also infrastructure stuff. There is a lot that needs to be done to be able to move the keyboards and keymaps, without breaking a bunch of stuff.

@ThePreviousOne
Copy link
Contributor Author

In what way, I cant see how it would be anymore complex than adding a line to the Docs about cloning the submodule 'if desired'.
Sorry if that sounds argumentative, I'm really just curious and trying to understand.

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 12, 2022
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.
// [stale-action-closed]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted question stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

No branches or pull requests

3 participants