Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [QP] Fonts don't render with --no-ascii --unicode-glyphs "..." #20624

Closed
2 tasks
tzarc opened this issue Apr 29, 2023 · 1 comment · Fixed by #20637
Closed
2 tasks

[Bug] [QP] Fonts don't render with --no-ascii --unicode-glyphs "..." #20624

tzarc opened this issue Apr 29, 2023 · 1 comment · Fixed by #20637

Comments

@tzarc
Copy link
Member

tzarc commented Apr 29, 2023

Describe the Bug

If disabling ASCII glyph generation, then supplying a subset of ASCII glyphs in order to only include needed glyphs, subsequent rendering of those glyphs at runtime doesn't work.

Keyboard Used

tzarc/djinn

Link to product page (if applicable)

Operating System

qmk doctor Output

-

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

Additional Context

@sigprof
Copy link
Contributor

sigprof commented Apr 29, 2023

The unicode branch of qp_drawtext_prepare_glyph_for_render() has:

                uint32_t data_offset  = sizeof(qff_font_descriptor_v1_t)
                            // Skip the font descriptor
                                       + sizeof(qff_ascii_glyph_table_v1_t)
                            // Skip the ascii table

That + sizeof(qff_ascii_glyph_table_v1_t) probably needs to be + (qff_font->has_ascii_table ? sizeof(qff_ascii_glyph_table_v1_t) : 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants