[Bug] Plank Light Sleep issues

[drashna]

Describe the Bug

The Planck Light does not properly sleep when the computer it's attached to does.

Found out that this is because NO_USB_STARTUP_CHECK is defined, which blocks this code. Undefining this allows it to turn off.

However, it has some issues with audio.
Specifically, it re-inits the board, like it crashes. So it plays the startup sound when it shouldn't be.

So, it looks like (well, sounds like, really) there is an issue with the sleep/idle code for the AT90USB1286 chip that needs to be handled differently. My guess is the watchdog timeout code is the issue. But I'm not sure about that, nor do I know how to fix this.

qmk_firmware/tmk_core/common/avr/suspend.c

Lines 230 to 242 in d5dcf54

	#ifndef NO_SUSPEND_POWER_DOWN
	/* watchdog timeout */
	ISR(WDT_vect) {
	// compensate timer for sleep
	switch (wdt_timeout) {
	case WDTO_15MS:
	timer_count += 15 + 2; // WDTO_15MS + 2(from observation)
	break;
	default:
	;
	}
	}
	#endif

System Information

• Keyboard: Planck Light
  • Revision (if applicable): Light
• Operating system: Win 10
• AVR GCC version: 7.3.1
• QMK Firmware version: 0.6.303
• Any keyboard related software installed?
  • AutoHotKey
  • Karabiner
  • Other:

[drashna]

Doesn't seem to be an issue, anymore.