Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] QMK doctor only checks /etc/udev/rules.d for udev rules. #9906

Open
3 tasks
bbaserdem opened this issue Aug 1, 2020 · 3 comments
Open
3 tasks

[Bug] QMK doctor only checks /etc/udev/rules.d for udev rules. #9906

bbaserdem opened this issue Aug 1, 2020 · 3 comments
Assignees

Comments

@bbaserdem
Copy link
Contributor

bbaserdem commented Aug 1, 2020

The doctor command in qmk python library fails to find the correct rules in /usr/lib/udev/rules.d directory.

Describe the Bug

The doctor command in QMK python library only checks a hard coded /etc/udev/rules.d for udev rules. Which works fine if you put your rules there. But these rules can also be located in /usr/lib/udev/rules.d; and actually is the preferred location for linux package managers to drop their udev rules. I recently packaged the python client in archlinux; and also provided neccessary udev rules along with it. After switching to these rules, I noticed I was getting warnings from qmk doctor when I had the correct udev rules in place.

System Information

  • Keyboard: N/A
  • Operating system: Archlinux
  • AVR GCC version: 10.1.0
  • ARM GCC version: 10.1.0
  • QMK Firmware version: 0.9.46
  • Any keyboard related software installed?
    • Karabiner
    • Other:
    • AutoHotKey

Additional Context

I also implemented a quick fix; and issued the pull request #9907

@zvecr
Copy link
Member

zvecr commented Aug 1, 2020

As a note https://aur.archlinux.org/packages/qmk exists and mentioned in the install docs on Arch-based distros you can also try the qmk package from AUR (note: it’s maintained by a community member): yay -S qmk).

@bbaserdem
Copy link
Contributor Author

bbaserdem commented Aug 1, 2020

@zverc The aforementioned package stealth installs python-hjson python package without seperately packaging it (very bad practice) and uses pip to do so (another bad practice). After I contacted the maintainer without response, (granted I did not wait longer than a day; but still has not responded) I repackaged both python-qmk and python-hjson in the AUR to fit archlinux packaging guidelines better; since I cannot change a package that another user has submitted. (unless the user adds me as a comaintainer)

In general; I'm against advertising any PKGBUILD in the AUR as an installation option. Pip installation instructions are sufficient in the docs.

@Foxboron
Copy link
Contributor

Honestly, is hjson needed? It's used one place to somehow streamline the parsing of some JSON data. But it seems like a rather unorganized project with no releases since 2014. Could we check if it's possible to remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants