Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature_macros.md #15026

Merged
merged 2 commits into from
Dec 27, 2021
Merged

Update feature_macros.md #15026

merged 2 commits into from
Dec 27, 2021

Conversation

Buttenup
Copy link

@Buttenup Buttenup commented Nov 2, 2021

Added a link to the usage of SAFE_RANGE as this wasn't clear to me when I visited this page in isolation.

Description

I came here recently to create some simple macros on my new board, the usage of SAFE_RANGE wasn't clear to me and omitting it leads to errors that seem unrelated when you don't know what it's for. I added a note that it should be used and a link to the page that explains it more clearly.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • [ x] Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Added a link to the usage of SAFE_RANGE as this wasn't clear to me when I visited this page in isolation.
@tzarc tzarc merged commit db358d1 into qmk:master Dec 27, 2021
tiktuk pushed a commit to tiktuk/qmk_firmware that referenced this pull request Jan 1, 2022
* Update feature_macros.md

Added a link to the usage of SAFE_RANGE as this wasn't clear to me when I visited this page in isolation.

* Fix typo

Co-authored-by: Nick Brassel <[email protected]>
ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022
* Update feature_macros.md

Added a link to the usage of SAFE_RANGE as this wasn't clear to me when I visited this page in isolation.

* Fix typo

Co-authored-by: Nick Brassel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants