Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Graystudio Apollo80 #16469

Merged
merged 14 commits into from
Mar 23, 2022
Merged

Conversation

ChrisBeswick
Copy link

@ChrisBeswick ChrisBeswick commented Feb 27, 2022

Added the Apollo 80 TKL keyboard by Graystudio on behalf of Demo Studio. Added documention for the board and cleaned up the formatting in some of the files.

Description

Added Apollo 80

  • Default keymap
  • Via Keymap

Both the Default and Via hex files have been built and tested on PCBs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 27, 2022
@ChrisBeswick ChrisBeswick changed the title Added a new keyboard:Graystudio/Apollo80 [Keyboard] Graystudio Apollo80 Feb 27, 2022
@ChrisBeswick ChrisBeswick requested a review from zvecr February 27, 2022 18:51
ChrisBeswick and others added 3 commits March 7, 2022 11:14
… BOOTMAGIC_ENABLE


Comment referenced Virtual Dip switch Configuration instead of Bootmagic Lite

Co-authored-by: Drashna Jaelre <[email protected]>
…tion from comment on AUDIO_ENABLE variable


Removed " on port C6" from the comment on the AUDIO_ENABLE variable.

Co-authored-by: Drashna Jaelre <[email protected]>
…licit animations instead of all


Defined all animations separately instead of using #define RGBLIGHT_ANIMATIONS as to better support future updates

Co-authored-by: Drashna Jaelre <[email protected]>
@ChrisBeswick ChrisBeswick requested a review from drashna March 8, 2022 10:44
Updated the Readme.md file to contain instructions on getting into the bootloader. Customised these instructions to the PCB
Removed commented out animations left over from a previous commit & Cleaned up if block
@ChrisBeswick ChrisBeswick requested a review from drashna March 8, 2022 17:25
…on as RESET is bound to ESC on the MO(1) layer.
…ut of the root config.h file:

#define RGBLIGHT_LAYERS
#define RGBLIGHT_LAYERS_OVERRIDE_RGB_OFF
@ChrisBeswick ChrisBeswick requested a review from drashna March 10, 2022 19:47
@ChrisBeswick
Copy link
Author

Hey. It’s been a week - could I get a re review on this please?

Cheers

@drashna drashna requested a review from a team March 17, 2022 22:09
Changed comment from "USB NKey Rollover" to "Enable N-Key Rollover"

Co-authored-by: Ryan <[email protected]>
Fixed issue where KC_J had been replaced with KC_A on the Default Keymap
Replaced KC_SPC on split left shift, split backspace and split right shift with more sensible values (KC_NUBS, KC_BSPC and KC_RSFT respectively)
@drashna drashna merged commit 28bd777 into qmk:master Mar 23, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants