Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stm32f4 uF2 prompt the problem of insufficient EEPROM #16750

Closed
wants to merge 91 commits into from
Closed

Stm32f4 uF2 prompt the problem of insufficient EEPROM #16750

wants to merge 91 commits into from

Conversation

swkidden
Copy link

@swkidden swkidden commented Mar 30, 2022 •
edited by zvecr
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Mar 30, 2022
zvecr
zvecr requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also #16287 (comment) and #16586 for why this change isnt enough on its own.

platforms/chibios/eeprom_stm32_defs.h
@@ -34,7 +34,7 @@
# endif
# elif defined(STM32F401xC) || defined(STM32F401xE) || defined(STM32F405xG) || defined(STM32F411xE)
# ifndef FEE_PAGE_SIZE
# define FEE_PAGE_SIZE 0x4000 // Page size = 16KByte
# define FEE_PAGE_SIZE 0x4000// Page size = 16KByte
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# define FEE_PAGE_SIZE 0x4000// Page size = 16KByte
# define FEE_PAGE_SIZE 0x4000 // Page size = 16KByte

builddefs/common_features.mk
@@ -183,7 +183,7 @@ else
ifeq ($(PLATFORM),AVR)
# Automatically provided by avr-libc, nothing required
else ifeq ($(PLATFORM),CHIBIOS)
ifneq ($(filter STM32F3xx_% STM32F1xx_% %_STM32F401xC %_STM32F401xE %_STM32F405xG %_STM32F411xE %_STM32F072xB %_STM32F042x6 %_GD32VF103xB %_GD32VF103x8, $(MCU_SERIES)_$(MCU_LDSCRIPT)),)
ifneq ($(filter STM32F3xx_% STM32F1xx_% %_STM32F401xC%_STM32F401xC_tinyuf2 % %_STM32F401xE %_STM32F405xG %_STM32F411xE %_STM32F411xE_tinyuf2 %_STM32F072xB %_STM32F042x6 %_GD32VF103xB %_GD32VF103x8, $(MCU_SERIES)_$(MCU_LDSCRIPT)),)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ifneq ($(filter STM32F3xx_% STM32F1xx_% %_STM32F401xC%_STM32F401xC_tinyuf2 % %_STM32F401xE %_STM32F405xG %_STM32F411xE %_STM32F411xE_tinyuf2 %_STM32F072xB %_STM32F042x6 %_GD32VF103xB %_GD32VF103x8, $(MCU_SERIES)_$(MCU_LDSCRIPT)),)
ifneq ($(filter STM32F3xx_% STM32F1xx_% %_STM32F401xC %_STM32F401xC_tinyuf2 %_STM32F401xE %_STM32F405xG %_STM32F411xE %_STM32F411xE_tinyuf2 %_STM32F072xB %_STM32F042x6 %_GD32VF103xB %_GD32VF103x8, $(MCU_SERIES)_$(MCU_LDSCRIPT)),)

@zvecr zvecr changed the base branch from master to develop March 30, 2022 18:59
sigprof
sigprof requested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes that are done here are incomplete — you also need to change FEE_PAGE_BASE_ADDRESS (the default value used on F4x1 would leave only 16 KiB for the bootloader, which is apparently not enough). From #16287 (comment) it seems that the flash portion reserved for the bootloader code is 32 KiB, and sectors 2 and 3 can be used for EEPROM.

@github-actions github-actions bot added CI cli qmk cli command documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support labels May 1, 2022
tzarc and others added 14 commits May 29, 2022 09:07
@tzarc
Fixup command sequencing for master/develop. (qmk#17227)
89a5d5a
@waffle87
Fixup iron165r2 (qmk#17119)
07f5147 
* initial

* revert some defines

* formatting

* apply changes

* update readme

* suggestion
@zvecr
Fix quark_lp via firmware size (qmk#17233)
6a0ed63
@zvecr
Use correct container for unit test workflow (qmk#17242)
e22a183
@zvecr
Fix API errors (qmk#17239)
a06b5ca
@SethBarberee
[Keymap] Update sethbarberee code to QK_BOOT and try out DVVORAK (qmk…
cc7a3f8 
…#17230)
@JunoNgx
[Keymap] Updates to layouts/community/ortho_4x12/junonum (qmk#17249)
15a86d5
@gaclee3b @drashna @fauxpark
[Keyboard] Add str.merro60 pcb (qmk#17097)
3826fca 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Alexander Lee <[email protected]>
Co-authored-by: chalex <[email protected]>
@daskygit
Fix docs typo (qmk#17254)
25ec68c
@zvecr
Fix various lint errors (qmk#17255)
2879573 
* Fix various lint errors

* reduce complexity
@zvecr
Convert ergodone to use core mcp23018 driver (qmk#17005)
0e11b51
@sigprof
Nix shell updates (qmk#17243)
650be92
@trwnh
Change AW20216 SPI Mode from 0 to 3, to fix RGB LEDs on GMMK Pro (qmk…
b554e4b 
…#17262)
@drashna
[Keymap] Drashna update for post Q2 merge (qmk#17241)
cda343a
Altainworks and others added 25 commits June 12, 2022 22:14
@Altainworks @fauxpark
[Keyboard] Add BLASTER75 keyboard (qmk#16887)
5149728 
Co-authored-by: Ryan <[email protected]>
@npspears @zvecr @drashna
[Keyboard] add SNOP60 (qmk#17131)
e49fa43 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
@keyboard-magpie
Update feature_midi.md (qmk#17390)
026d0e8 
Add caveat about usb endpoints.
@tzarc
Inform people that things may not work. (qmk#17391)
15dab01
@zvecr
Perform stricter lint checks (qmk#17348)
f37de9a
@lazho
[Keyboard] Flip encoder pads on basketweave (qmk#17375)
1c45845
@str-dst @drashna
[Keyboard] Add Chaos65 keyboard (qmk#17369)
dc2ce36 
Co-authored-by: Drashna Jaelre <[email protected]>
@forrcaho
[Keymap] New keymap for Keebio FoldKB (qmk#17364)
b7ce3b1
@ADPenrose
[Keymap+] SnailMap port for the Kintsugi keyboard. (qmk#17341)
de207b9
@Altainworks
BLASTER75 info.json position fixes (qmk#17395)
afbba27
@Felicious
edit typo in comment (qmk#17394)
7224d84
@zvecr
Fix clean arg handling (qmk#17392)
d3dfa83
@IBNobody @drashna
@fauxpark @silvinor
[Keyboard] Add Idobao Montex RGB (V2) (qmk#16897)
8e5f8a5 
* Add Montex V2 (qmk#10)

* Update readme.md

* Update rules.mk

* Update config.h

* Update keyboards/idobao/montex/v2/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/idobao/montex/v2/rules.mk

Add Layouts

Co-authored-by: Drashna Jaelre <[email protected]>

* Merged code fron work done with @vinorodrigues

* Update keyboards/idobao/montex/v2/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/idobao/montex/v2/v2.h

Co-authored-by: Ryan <[email protected]>

* Update keyboards/idobao/montex/v2/config.h

Co-authored-by: Ryan <[email protected]>

* Removing via_nug keymap

* update to montex code (qmk#11)

* remove VIA_QMK_RGBLIGHT_ENABLE

* more data driven config, simple copyright headers, some code cleanup

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Vino Rodrigues <[email protected]>
@peepeetee @drashna
@chofstede @silvinor
[Keyboard] Idobao Montex V2(RGB) (qmk#15865)
8e12845 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Christian Hofstede <[email protected]>
Co-authored-by: Vino Rodrigues <[email protected]>
Co-authored-by: Vino Rodrigues <[email protected]>
@lleonini @fauxpark
[Keyboard] Add ADM42 Keyboard (qmk#17366)
8be0496 
Co-authored-by: Ryan <[email protected]>
@tzarc
Swap to actions/stale. (qmk#17404)
5ccb2fd
@yoshimaru46
[Keymap] Update yoshimaru46 keymap (qmk#17402)
811dbda
@minibois @drashna @fauxpark
[Keyboard] mini_ten_key_plus edited info.json (qmk#15574)
6d7026e 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
@gpalumbo
[Keyboard] Fix 1U space in Keebio/sinc/rev2 layout macros (qmk#16901)
89921e9
@Michal-Szczepaniak @drashna
[handwired/macroboard] Add separate f401 and f411 configs… (qmk#16338)
82a7f4a 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @fauxpark
[Keyboard] Atreus: add STM32F103C8T6 based variant (qmk#16846)
6d2f9c9 
Co-authored-by: Ryan <[email protected]>
@waffle87
Fixup handwired/macroboard (qmk#17405)
545923b
@tzarc
Fixup stale labels lists. (qmk#17415)
b5104c3
@coliss86
Add a note about using differents MCU family (qmk#17416)
fd01fea
@swkidden
Merge branch 'qmk:master' into master
fd6ba18
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 14, 2022
@zvecr
Copy link
Member

zvecr commented Aug 14, 2022

Superseded by #18042

@zvecr zvecr closed this Aug 14, 2022
@zvecr zvecr mentioned this pull request Aug 14, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprof sigprof sigprof requested changes

@zvecr zvecr zvecr requested changes

Assignees
No one assigned
Labels
CI cli qmk cli command core documentation enhancement keyboard keymap python stale Issues or pull requests that have become inactive without resolution. translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.