Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard] rename id80 v1 to v2 to clear up confusion #17054

Closed
wants to merge 72 commits into from
Closed

[keyboard] rename id80 v1 to v2 to clear up confusion #17054

wants to merge 72 commits into from

Conversation

silvinor
Copy link
Contributor

Description

IDOBAO support has received a few support calls with developers confused with the "v1" name used in the folder structure introduced in #15992.

The code in the v1 folder is perfectly suited to the current v2 boards and correct naming will prevent developers from inadvertently using v3 codebase in their v2 boards.

This PR seeks to rename the "v1" folder to "v2" (to eliminate confusion), and then add a readme.md and rules.mk file to the "v1" (ensuring backward compatibility).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 11, 2022
@silvinor silvinor changed the base branch from master to develop May 17, 2022 07:36
@silvinor silvinor marked this pull request as ready for review May 17, 2022 14:18
@tzarc
Copy link
Member

tzarc commented May 17, 2022

@vinorodrigues marked this pull request as ready for review 4 hours ago

Seems there are conflicts.

@silvinor
Copy link
Contributor Author

Seems there are conflicts.

Yes, sorry ... I wrote this off the master and was asked by @sigprof to PR to develop. The conflict is in @zvecr 's PR #17037 wherein the default/keymap.c and via/keymap.c files had RESET changed to QK_BOOT.

I did not rebase the code (or rather do not know how to), but the change is in there. Just don't have privilege to auto-resolve.

(I will try learning how to rebase...)

DmNosachev and others added 11 commits May 18, 2022 09:07
@DmNosachev @tzarc
kin80 (qmk#16754)
2797a4d 
Co-authored-by: Nick Brassel <[email protected]>
@nooges
[Keyboard] Add notes on Iris rev6a firmware (qmk#16878)
4b9b96a
@Jels02
Fixed error in config (qmk#16895)
3a37200
@Jpe230
Fix i2c driver doc: Incorrect name (qmk#16898)
a628876
@daskygit
[Keyboard] Fix kin80 default keymap (qmk#16893)
bc3d28f
@nomis
rgblight: Fix rgblight_blink_layer when multiple layers are active (q…
4a2d033 
…mk#16824)
@mtei
[Keymap] Fix build error helix:five_rows (qmk#16847)
e3c5cc7
@HorrorTroll
Added new keyboard Gas75 (qmk#16768)
8ce86d5
@Ladduro
Keychron Q2 add Caps Lock indicator and layer RGB (qmk#16641)
5b67266
@yiancar @drashna
Loki65 (qmk#16844)
1c5c502 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: yiancar <[email protected]>
@peepeetee
[Keyboard]Remove RGB light implementation of ID67, revert the file st…
121f8bf 
…ructure changes by qmk#15558 (qmk#15854)
Xelus22 and others added 22 commits May 18, 2022 09:07
@Xelus22
[Keyboard] RS60 Rev2 Addition (qmk#16988)
f7f9a40
@hineybush @zvecr @fauxpark
Add ibis PCB (qmk#17001)
d6e1b4d 
* initial ibis commit

* updates etc

* layout updates to fix mismatched keys

* Apply suggestions from code review

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/hineybush/ibis/info.json

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/hineybush/ibis/readme.md

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
@Xelus22
[Bug] Fix RS60 Rev2 I2C (qmk#17015)
b6f0c7e
@fauxpark
Ensure .hex file output for ARM Teensys (qmk#17014)
2c58edf
@Doomsdayrs @theVDude
Sol3 fix rgb map (qmk#17019)
0779538 
* Fix for key -> LED mapping

* Revert whitespace changes

* Revert whitespace changes 2

Co-authored-by: theVDude <[email protected]>
@GreatWizard
feat: add support for JJ50 VIA (qmk#16420)
2c55053
@jaygreco
Update RMKB to support SNAP (qmk#17042)
9a008b9
@8bits4ever @zvecr @drashna
converter/a1200/mistress1200: further firmware shrinking to fit on At…
535fde9 
…mega16U4 (16kb) (qmk#17040)

* Create dummy.txt

* Add files via upload

* Add files via upload

* Delete dummy.txt

* Update config.h

* Update rules.mk

* Update keymap.c

* Update keyboards/converter/a1200/mistress1200/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/converter/a1200/mistress1200/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/converter/a1200/mistress1200/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/converter/a1200/mistress1200/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/converter/a1200/mistress1200/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/converter/a1200/mistress1200/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/converter/a1200/mistress1200/rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* Update config.h

* Update rules.mk

* Update readme.md

* Update config.h

* Update rules.mk

* Update config.h

* Update keyboards/converter/a1200/mistress1200/config.h

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
@EugenePY @zvecr
@drashna @fauxpark
Adding akira (qmk#16982)
3659855 
* keyboard:akira initial commit

* Update keyboards/ekow/akira/akira.h

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/ekow/akira/keymaps/via/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/ekow/akira/readme.md

Co-authored-by: Joel Challis <[email protected]>

* Update .gitignore

Co-authored-by: Joel Challis <[email protected]>

* Update readme.md

* Update keyboards/ekow/akira/rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* Update rules.mk

remove redundant content.

* added keyboard/ekow/keymaps/via/keymap.c

* remove .ccls-cache

* add instructions of enter the bootloader

* add instructions of enter the bootloader

* modify ekow/akira:via

* Update keyboards/ekow/akira/readme.md

Co-authored-by: Ryan <[email protected]>

* Update keyboards/ekow/akira/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
@takashicompany
[Keyboard] Fix led num for center_enter/qoolee (qmk#17050)
c873dae
rename v1 to v2
a942c44
rename id80 v2 filenames
8d22f96
create V1 placeholder
56f50bb
rename ambiguous LAYOUT to LAYOUT_ansi
e82ee66
elaborate on v1 vs. v2 boards
ede8d93
ensure v1 folder compiles
2dc1865
Update info.json
21b5939
disable backlight for v1 boards
351cbde
updated v1 conditional compile to use BACKLIGHT_ENABLE=no
fc9f74a
additional code cleanup
3e6fa3d
RESET -> QK_BOOT default keymaps
51e3896
Merge branch 'vr-id80-v1-rename' of https://github.com/Idobao/qmk.qmk…
1a4f2ee 
…_firmware into vr-id80-v1-rename
@silvinor
Copy link
Contributor Author

@$%^#@^$%##$^%^! I broke it! Will redo in another PR --- starting with the correct base.

@silvinor silvinor closed this May 17, 2022
@silvinor silvinor deleted the vr-id80-v1-rename branch May 17, 2022 23:17
@silvinor
Copy link
Contributor Author

redone as #17137

@silvinor silvinor mentioned this pull request May 17, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.