Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore potential preprocessor logic when processing DD config #17460

Closed
wants to merge 4 commits into from
Closed

Ignore potential preprocessor logic when processing DD config #17460

wants to merge 4 commits into from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 23, 2022 •
edited
Loading

Description

Short term bodge for sol/rev2 issues?

Diff looks a bit gross as logic was reordered slightly to better match the undef pathway.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Jun 23, 2022
@zvecr zvecr marked this pull request as ready for review June 23, 2022 17:06
@zvecr zvecr requested a review from a team June 23, 2022 17:06
@zvecr zvecr marked this pull request as draft July 8, 2022 20:24
@zvecr zvecr mentioned this pull request Jul 8, 2022
Merged
14 tasks
@zvecr zvecr closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zvecr