Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add ibis80 #18051

Merged
merged 5 commits into from
Aug 17, 2022
Merged

[Keyboard] Add ibis80 #18051

merged 5 commits into from
Aug 17, 2022

Conversation

Runheme
Copy link

@Runheme Runheme commented Aug 15, 2022

Add ibis80

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 15, 2022
@Runheme @zvecr
Update keyboards/mokey/ibis80/config.h
18ccb94 
/*
Copyright 2021 Kyle McCreery
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program.  If not, see <http://www.gnu.org/licenses/>.
*/

#pragma once

#include "config_common.h"

/* USB Device descriptor parameter */
#define VENDOR_ID       0x6653
#define PRODUCT_ID      0x3380
#define DEVICE_VER      0x0001
#define MANUFACTURER    Mokey
#define PRODUCT         IBIS 80
/* key matrix size */
#define MATRIX_ROWS 6
#define MATRIX_COLS 17

#define MATRIX_ROW_PINS { B0, B1, B2, E6, F0, F1 }
#define MATRIX_COL_PINS { D0, D1, D2, D3, D5, D4, D6, D7, B4, B5, B6, C6, C7, F7, F6, F5, F4 }
#define UNUSED_PINS

/* COL2ROW, ROW2COL*/
#define DIODE_DIRECTION COL2ROW

/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5

Co-authored-by: Joel Challis <[email protected]>
drashna
drashna requested changes Aug 15, 2022
View reviewed changes
Runheme and others added 2 commits August 15, 2022 20:02
@Runheme @drashna
Update keyboards/mokey/ibis80/rules.mk
956f2f8 
# MCU name
MCU = atmega32u4

# Bootloader selection
BOOTLOADER = atmel-dfu

# Build Options
#   change yes to no to disable
#
BOOTMAGIC_ENABLE = yes     # Virtual DIP switch configuration
MOUSEKEY_ENABLE = yes       # Mouse keys
EXTRAKEY_ENABLE = yes       # Audio control and System control
CONSOLE_ENABLE = no         # Console for debug
COMMAND_ENABLE = no         # Commands for debug and configuration
# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE
SLEEP_LED_ENABLE = no       # Breathing sleep LED during USB suspend
# if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
NKRO_ENABLE = no            # USB Nkey Rollover
BACKLIGHT_ENABLE = no       # Enable keyboard backlight functionality
RGBLIGHT_ENABLE = no        # Enable keyboard RGB underglow
AUDIO_ENABLE = no           # Audio output

Co-authored-by: Drashna Jaelre <[email protected]>
@Runheme
Update rules.mk
b0e294b
@Runheme Runheme requested a review from drashna August 15, 2022 12:06
@drashna drashna requested a review from a team August 15, 2022 17:47
fauxpark
fauxpark requested changes Aug 16, 2022
View reviewed changes
@Runheme @fauxpark
Update keyboards/mokey/ibis80/rules.mk
cacb66e 
# MCU name
MCU = atmega32u4

# Bootloader selection
BOOTLOADER = atmel-dfu

# Build Options
#   change yes to no to disable
#
BOOTMAGIC_ENABLE = yes     # Enable Bootmagic Lite
MOUSEKEY_ENABLE = yes       # Mouse keys
EXTRAKEY_ENABLE = yes       # Audio control and System control
CONSOLE_ENABLE = no         # Console for debug
COMMAND_ENABLE = no         # Commands for debug and configuration
# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE
SLEEP_LED_ENABLE = no       # Breathing sleep LED during USB suspend
# if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
NKRO_ENABLE = no            # USB Nkey Rollover
BACKLIGHT_ENABLE = no       # Enable keyboard backlight functionality
RGBLIGHT_ENABLE = no        # Enable keyboard RGB underglow
AUDIO_ENABLE = no           # Audio output

Co-authored-by: Ryan <[email protected]>
@Runheme Runheme requested a review from fauxpark August 16, 2022 08:21
@drashna drashna merged commit e5f1d88 into qmk:master Aug 17, 2022
@Runheme Runheme mentioned this pull request Aug 17, 2022
Merged
6 tasks
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@Runheme @zvecr
@drashna @fauxpark @imhoffman
[Keyboard] Add ibis80 (qmk#18051)
79377c4 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
SjB added a commit to SjB/qmk_firmware that referenced this pull request Aug 27, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
021168a 
* upstream/master: (595 commits)
  [Keyboard] Add ibis80 (qmk#18051)
  [Keymap] toshi0383 keymaps update (qmk#18073)
  [Docs] Use layer number as example for COMBO_ONLY_FROM_LAYER (qmk#18072)
  [Keymap] jotix's community/ortho4x12 change (qmk#18069)
  Adjust the hierarchy of chapter `Deferred Execution` (qmk#18075)
  Fix WS2812 order for aurora65 and loki65 (qmk#18074)
  [Docs] update pr_checklist.md with info about data-driven (qmk#18068)
  Use correct board file in xelus/valor_frl_tkl/rev2_0 (qmk#18071)
  Migrate more F4x1 board files (qmk#18054)
  ADB to USB converter: split into rev1 and rev2 (qmk#18052)
  Move keyboard USB IDs and strings to data driven, pass 2: D-E (qmk#17956)
  Move keyboard USB IDs and strings to data driven, pass 2: F-I (qmk#17958)
  Allow disabling RGB_MATRIX_ANIMATIONS system76 keyboards (qmk#17478)
  Migrate more F4x1 board files (qmk#18046)
  Feat/port ft mars 65 (qmk#17994)
  Improve Drop Alt compatibility with VIA (qmk#18041)
  [Keyboard] Add Valor FRL TKL rev2.0 and 2.1 (qmk#17992)
  Move keyboard USB IDs and strings to data driven, pass 2: B-C (qmk#17945)
  [Keyboard] add bajjak keyboard (qmk#12377)
  Add texts for Discord Events to be created post-merge. (qmk#17944)
  ...
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@Runheme @zvecr
@drashna @fauxpark @nolanseaton
[Keyboard] Add ibis80 (qmk#18051)
4f9aebc 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Runheme @drashna @fauxpark @zvecr