Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support keyboard Epomaker TH66 #18904

Closed
wants to merge 4 commits into from
Closed

Conversation

HorrorTroll
Copy link
Contributor

Description

Added support keyboard Epomaker TH66

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 29, 2022
@drashna drashna requested a review from a team November 13, 2022 00:55
@TheMohawkNinja
Copy link

Not sure if some of the previous changes made to the original upload of the TH66 firmware resolves this, but I noticed my TH66 had a similar issue to the one presented in /issues/6726 (more specifically, turning the PC off without disconnecting the keyboard would result in apparent corruption of the firmware after some time had passed, necessitating re-flashing). The stated solution of adding #define NO_USB_STARTUP_CHECK to config.h also resolved my issue.

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 13, 2023
@HorrorTroll
Copy link
Contributor Author

HorrorTroll commented Apr 30, 2023

Done, updated the entire code with new info.json thing. If anyone have time, please take a look and help me review it

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label May 1, 2023
Comment on lines +20 to +55
#ifdef ENCODER_ENABLE
bool encoder_update_kb(uint8_t index, bool clockwise) {
if (!encoder_update_user(index, clockwise)) {
return false; /* Don't process further events if user function exists and returns false */
}
if (index == 0) { /* First encoder */
if (layer_state_is(0)) {
if (clockwise) {
tap_code(KC_VOLU);
} else {
tap_code(KC_VOLD);
}
} else if (layer_state_is(1)) {
if (clockwise) {
tap_code(KC_VOLU);
} else {
tap_code(KC_VOLD);
}
} else if (layer_state_is(2)) {
if (clockwise) {
tap_code(KC_TRNS);
} else {
tap_code(KC_TRNS);
}
} else if (layer_state_is(3)) {
if (clockwise) {
tap_code(KC_TRNS);
} else {
tap_code(KC_TRNS);
}
}
}
return true;
}
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is/will be the core default behaviour.

Suggested change
#ifdef ENCODER_ENABLE
bool encoder_update_kb(uint8_t index, bool clockwise) {
if (!encoder_update_user(index, clockwise)) {
return false; /* Don't process further events if user function exists and returns false */
}
if (index == 0) { /* First encoder */
if (layer_state_is(0)) {
if (clockwise) {
tap_code(KC_VOLU);
} else {
tap_code(KC_VOLD);
}
} else if (layer_state_is(1)) {
if (clockwise) {
tap_code(KC_VOLU);
} else {
tap_code(KC_VOLD);
}
} else if (layer_state_is(2)) {
if (clockwise) {
tap_code(KC_TRNS);
} else {
tap_code(KC_TRNS);
}
} else if (layer_state_is(3)) {
if (clockwise) {
tap_code(KC_TRNS);
} else {
tap_code(KC_TRNS);
}
}
}
return true;
}
#endif

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 28, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants