Refactor process_unicode_common code + make keys used for UC_WINC and UC_OSX configurable #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vomindoraan
force-pushed
the
unicode_common_cleanup
branch
from
a685b70 to
c9ace04
Compare
vomindoraan
changed the title
vomindoraan
force-pushed
the
unicode_common_cleanup
branch
5 times, most recently
from
1ce34ce to
436c6dc
Compare
vomindoraan
changed the title
vomindoraan
changed the title
vomindoraan
force-pushed
the
unicode_common_cleanup
branch
6 times, most recently
from
c23fa63 to
e7ca38f
Compare
drashna
reviewed
Oct 23, 2018
drashna
approved these changes
Oct 23, 2018
vomindoraan
force-pushed
the
unicode_common_cleanup
branch
from
e7ca38f to
8e36e5a
Compare
|
I've tested this with my existing keymaps that have Unicode in them on all three platforms (many thanks to my coworkers who lent me their Macs!). If anyone else could double-check with their own keymaps, that would be great. |
vomindoraan
force-pushed
the
unicode_common_cleanup
branch
2 times, most recently
from
6a6f74f to
90585eb
Compare
Closed
2 tasks
vomindoraan
force-pushed
the
unicode_common_cleanup
branch
from
90585eb to
ba32b8e
Compare
2 tasks
|
Can any of the maintainers provide an eta on when this might be merged? A keymap that I'm putting together is heavily reliant on the exact functionality that this PR provides. Cheers! |
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
Co-Authored-By: drashna <[email protected]>
* case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms
Co-Authored-By: vomindoraan ([email protected])
Co-Authored-By: drashna <[email protected]>
|
These changes have been incorporated into #4325. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: drashna:make_unicode_init has been merged into this as #4325 will likely be merged soon.
If you are reviewing this, click here to view the changes from that branch to this one. Those are the actual changes that this PR will introduce once #4325 is merged.
The old changes are available on vomindoraan:unicode_common_cleanup_backup.
While working on new Unicode features, I noticed some parts of
process_unicode_common.*were written in a verbose and outdated way. There were also some unnecessary bits, like the unusedstatic uint8_t input_modein the header. This PR cleans up that code.I've also made the key used by the WinCompose input mode configurable, as this key can be set by the user in WinCompose options. The default is
KC_RALTso that existing behavior is preserved by default.I've removed
UC_OSX_RALT(which worked the same asUC_OSX, it just sentKC_RALTinstead ofKC_LALT) in favor of making the sent key configurable.UC_OSX_RALTwasn't being used in any keymap. The default isKC_LALTso that existing behavior is preserved by default.The corresponding doc entries have been updated as well.
These changes should not affect existing behavior in any way.
@drashna Please review if you can.
Thanks.