Remove CUSTOM_MATRIX option from diode direction #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
There is a merge conflict. :( |
|
@drashna thanks for the heads up, I will fix the issue ASAP. The merge conflict has at least flagged with me, that this will need a 2nd pass in the future for any boards added against the previous code base. |
zvecr
force-pushed
the
feature/remove_diode_CUSTOM_MATRIX
branch
2 times, most recently
from
1aca6fb to
f46b301
Compare
drashna
approved these changes
Feb 12, 2019
|
Well, I'll try to catch the text in future PRs. Can't make any promises though. And either still a merge conflict or another has popped up. |
zvecr
force-pushed
the
feature/remove_diode_CUSTOM_MATRIX
branch
from
f46b301 to
04a3762
Compare
|
@drashna was another commit, i have updated again to reflect the current state of master. |
|
Thanks @drashna, i will schedule a 2nd pass for any that slip through. |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 2, 2019
* Remove CUSTOM_MATRIX refs from DIODE_DIRECTION * Remove '#define DIODE_DIRECTION CUSTOM_MATRIX' * Remove CUSTOM_MATRIX refs from DIODE_DIRECTION documentation
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Remove CUSTOM_MATRIX refs from DIODE_DIRECTION * Remove '#define DIODE_DIRECTION CUSTOM_MATRIX' * Remove CUSTOM_MATRIX refs from DIODE_DIRECTION documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussion within #5026
There seems to be an existing comment, both within the docs, templates and code base,
However digging into the implementation, it currently does not do much. Currently if you set the documented option (both in the existing template and online docs)
DIODE_DIRECTION = CUSTOM_MATRIXyou end up with a matrix.c being included that will not function at all, and no clean way to implement anything that fixes that.This PR removes the option, via find replace. In a future PR (or maybe this one if requested), functionality will be added to provide warnings or messages when the above 'broken matrix.c' is encountered.
Types of changes
Issues Fixed or Closed by this PR
Checklist: