Port DIRECT_PINS from split_common/matrix.c to matrix.c #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
…matrix.c - fix logic from inherited from split_common
Diodes aren't the defining feature of the wiring system, so it's not really correct to mention them here. Something more like the following would be better: "To configure a keyboard where each switch is connected to a separate pin and ground instead of sharing row and column pins, use |
|
Other than getting the documentation right, this looks good (although I'm obviously going to say that, having written the original code.) Thanks for doing this! |
drashna
approved these changes
Feb 12, 2019
|
There are some merge conflicts here. |
|
@drashna thanks for the heads up, I have fixed the merge issue. |
13 tasks
|
Looks like another use case with #5266. |
|
Staryu also requires this change as it defines the matrix as |
13 tasks
mechmerlin
approved these changes
Apr 11, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Apr 12, 2019
* Port DIRECT_PINS from split_common/matrix.c to matrix.c * Reorder matrix.c to remove foward declaration and match split_common/matrix.c * Refactor nano to use DIRECT_PINS * Reorder matrix.c to remove foward declaration and match split_common/matrix.c * Add DIRECT_PINS documentation * Reorder matrix.c to remove foward declaration and match split_common/matrix.c - fix logic from inherited from split_common * Add DIRECT_PINS documentation - review comments
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Apr 14, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (101 commits) Change table names Cleanup code Make send_char multilined for readaability Clean up some of the code Add AltGr/RALT support to Send String Add vendor and product arguments to atmega32a_program.py - fix hex print Add vendor and product arguments to atmega32a_program.py Max out range for max compatibility Fix ATSAM's USB HID descriptor to support higher heycodes Fix build detection of keymap and board changes Apply MAKEFLAGS to speed up CI Flesh out keymaps and some tweaks to indicators (qmk#5608) add in the missing #defines Update ps2avrgb readme template (qmk#5584) Use DIRECT_PINS for BDN9 (qmk#5603) Port DIRECT_PINS from split_common/matrix.c to matrix.c (qmk#5091) Keyboard: Add yosino58 Keyboard (qmk#5465) fix offset in matrix (qmk#5600) Remove caveat about combos with shared keys (qmk#5601) Revert "Update build instructions and docker file to download submodules" (qmk#5533) ...
fdidron
added a commit
to zsa/qmk_firmware
that referenced
this pull request
Apr 16, 2019
Port DIRECT_PINS from split_common/matrix.c to matrix.c (qmk#5091)
shimesaba-type0
pushed a commit
to shimesaba-type0/qmk_firmware
that referenced
this pull request
Jun 22, 2019
* Port DIRECT_PINS from split_common/matrix.c to matrix.c * Reorder matrix.c to remove foward declaration and match split_common/matrix.c * Refactor nano to use DIRECT_PINS * Reorder matrix.c to remove foward declaration and match split_common/matrix.c * Add DIRECT_PINS documentation * Reorder matrix.c to remove foward declaration and match split_common/matrix.c - fix logic from inherited from split_common * Add DIRECT_PINS documentation - review comments
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* Port DIRECT_PINS from split_common/matrix.c to matrix.c * Reorder matrix.c to remove foward declaration and match split_common/matrix.c * Refactor nano to use DIRECT_PINS * Reorder matrix.c to remove foward declaration and match split_common/matrix.c * Add DIRECT_PINS documentation * Reorder matrix.c to remove foward declaration and match split_common/matrix.c - fix logic from inherited from split_common * Add DIRECT_PINS documentation - review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussion within #5026
split_common already contains a method of mapping pins when diodes are not used,
DIRECT_PINS. This is currently missing from the non splitmatrix.c.This PR aligns some of the functionality of
matrix.candsplit_common/matrix.cas well as reorders some of the functions to aid diff-ability. Finally i have added docs for theDIRECT_PINSoption.As a review hint, it might help to go via the commit history, as the moving of functions was done after the main functionality was added.
Types of changes
Issues Fixed or Closed by this PR
Checklist: