Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NO_PIN guards before setPinXXX() #5165

Closed
wants to merge 1 commit into from

Conversation

kaylanm
Copy link
Contributor

@kaylanm kaylanm commented Feb 18, 2019

Description

The keeb.io BDN9 macropad is one of two boards that use NO_PIN in their config.h. When the BDN9 is compiled & run on a Proton-C with CONVERT_TO_PROTON_C=yes, the firmware crashes and the user receives 'USB device descriptor request failed.' I've added guards to prevent this that mimic the ones in quantum/split_common/matrix.c for the purpose of discussion, but if NO_PIN should not be a thing, this can easily go another direction.

cc: @nooges

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@pelrun
Copy link
Contributor

pelrun commented Feb 18, 2019

This confused me because #5091 isn't merged yet.

BDN9 seems to be using a hacky method of getting DIRECT_PINS behaviour while specifying COL2ROW. The proper fix is to convert it to use DIRECT_PINS once #5091 lands. Before that you could change the bogus row pin to a real unused pin instead.

@kaylanm
Copy link
Contributor Author

kaylanm commented Feb 18, 2019

Perfect, thanks.

@kaylanm kaylanm closed this Feb 18, 2019
@kaylanm kaylanm deleted the proton-c-no-pin branch April 11, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants