Add NO_PIN guards before setPinXXX() #5165
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The keeb.io BDN9 macropad is one of two boards that use
NO_PIN
in theirconfig.h
. When the BDN9 is compiled & run on a Proton-C withCONVERT_TO_PROTON_C=yes
, the firmware crashes and the user receives 'USB device descriptor request failed.' I've added guards to prevent this that mimic the ones inquantum/split_common/matrix.c
for the purpose of discussion, but ifNO_PIN
should not be a thing, this can easily go another direction.cc: @nooges
Types of Changes
Checklist