Refactor staryu to current standards and enable support for backlight keycode #5487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
force-pushed
the
feature/tidy_staryu
branch
from
9b220a0 to
6de7be2
Compare
|
Thanks for the heads up! |
drashna
approved these changes
Mar 27, 2019
|
Looks good, thanks! |
chie4hao
pushed a commit
to chie4hao/qmk_firmware
that referenced
this pull request
Mar 28, 2019
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Mar 28, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (75 commits) [Keyboard] E6V2 Bootmapper Client QMK port (qmk#5495) [Keymap] Add kwer keymap and RGB mod description to cypher (qmk#5479) [Keymap] added user keymap (qmk#5499) build size-check enhancement (qmk#5485) [Keyboard] Add Collide39 keyboard (qmk#5486) [Docs] Add udev rule for Input Club bootloaders (qmk#5494) [Keymap] adding keymaps (qmk#3583) Add 3 speed mousekey movement option (qmk#2246) [Keymap] add redox/rev1:fculpo keymap (qmk#5491) [Keymap] Update iris default (qmk#5489) Refactor staryu to current standards and enable support for backlight keycodes (qmk#5487) Fixing Ergodox_EZ rgb_led initialization Added songs from Nier and Nier Automata Document an annoyance with Grave Escape and macOS Terminal (qmk#5483) Bugfix for recently integrated cypher keyboard (qmk#5481) add keyboards/mxss/rgblight.h from e661f15:quantum/rgblight.h (qmk#5461) [Keymap] Planck Keymap :: rjhiglefort (qmk#5059) Add support for RGB LEDs wired directly to each half's controller (qmk#5392) [Keyboard] added cypher keyboard support (qmk#5466) [Keymap] Add custom Planck Light keymap (qmk#5464) ...
danielo515
pushed a commit
to danielo515/qmk_firmware
that referenced
this pull request
May 15, 2019
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor staryu to current standards;
'#pragma onceNO_PINfor when Port DIRECT_PINS from split_common/matrix.c to matrix.c #5091 dropsEnable support for backlight keycodes;
backlight_led_onandbacklight_led_offfunctions in case they are required for keymaps in a forkTypes of Changes
Issues Fixed or Closed by This PR
Checklist