Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DIRECT_PINS for BDN9 #5603

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Use DIRECT_PINS for BDN9 #5603

merged 1 commit into from
Apr 11, 2019

Conversation

kaylanm
Copy link
Contributor

@kaylanm kaylanm commented Apr 11, 2019

Description

Now that #5091 (DIRECT_PINS support) is merged, migrate BDN9 to use it. Fixes inability to use BDN9 with Proton-C.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mechmerlin
Copy link
Contributor

Checked in with @nooges aka bakingpy and he's cool with the change.

@mechmerlin mechmerlin merged commit c78bc6a into qmk:master Apr 11, 2019
@kaylanm kaylanm deleted the bdn9-direct-pins branch April 11, 2019 19:29
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Apr 14, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (101 commits)
  Change table names
  Cleanup code
  Make send_char multilined for readaability
  Clean up some of the code
  Add AltGr/RALT support to Send String
  Add vendor and product arguments to atmega32a_program.py - fix hex print
  Add vendor and product arguments to atmega32a_program.py
  Max out range for max compatibility
  Fix ATSAM's USB HID descriptor to support higher heycodes
  Fix build detection of keymap and board changes
  Apply MAKEFLAGS to speed up CI
  Flesh out keymaps and some tweaks to indicators (qmk#5608)
  add in the missing #defines
  Update ps2avrgb readme template (qmk#5584)
  Use DIRECT_PINS for BDN9 (qmk#5603)
  Port DIRECT_PINS from split_common/matrix.c to matrix.c (qmk#5091)
  Keyboard: Add yosino58 Keyboard (qmk#5465)
  fix offset in matrix (qmk#5600)
  Remove caveat about combos with shared keys (qmk#5601)
  Revert "Update build instructions and docker file to download submodules" (qmk#5533)
  ...
shimesaba-type0 pushed a commit to shimesaba-type0/qmk_firmware that referenced this pull request Jun 22, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants