Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keymap for idobo #6250

Merged
merged 11 commits into from
Jul 7, 2019
Merged

keymap for idobo #6250

merged 11 commits into from
Jul 7, 2019

Conversation

GreenShadowMaker
Copy link
Contributor

Description

Keymap updates for my idobo kemap

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Jul 4, 2019
View reviewed changes
keyboards/idobo/keymaps/greenshadowmaker/keymap.c Outdated
}
return false;
break;
case ADJUST:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like this keycode is used in the keymap, so this case can be removed, along with the ntry in the custom_keycodes enum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which keycode, I'm using each of the layers? Not sure if I needed the lower/raise/adjust thing here.. or if it's in base qmk now and I can discard in my keymap. (taken from a different keymap example, but can't say which, as it was too long ago.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole case block here - the keycode ADJUST and the layer name _ADJUST are separate things, and you can still access the adjust layer by holding LOWER and RAISE simultaneously - that's what the update_tri_layer() stuff above is all about.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh!, Since I don't have a key mapped to "ADJUST" your saying the adjust case should be removed? The update_tri_layer with the lower/raise on it's own will take care of going to the Adjust layer when both are pressed.

Should the QWERTY = SAFE_RANGE, be removed from custom_keycodes also?

Thanks!!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, actually, I didn't notice 😄 But you should then add the = SAFE_RANGE, to the LOWER keycode instead, otherwise the enum will start at 0 instead of the custom keycode range.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified, thanks!!

noroadsleft
noroadsleft approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

mechmerlin
mechmerlin approved these changes Jul 7, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit a07da6e into qmk:master Jul 7, 2019
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@GreenShadowMaker @doughsay
keymap for idobo (qmk#6250)
1b170dd 
* greenshadowmaker keymap for idobo xd75 massdrop

* remove uneeded config.h

* corrected format to match convention instead of xd75 where I accidentally started from

* fixed errors and added arrows bottom right to match my other layouts

* updated readme

* right arrow fix

* Update keyboards/idobo/keymaps/greenshadowmaker/keymap.c

removing unnecessary part, copied from different keymap

Co-Authored-By: fauxpark <[email protected]>

* added suggested changes

* removed unneded elements
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@GreenShadowMaker
keymap for idobo (qmk#6250)
d385197 
* greenshadowmaker keymap for idobo xd75 massdrop

* remove uneeded config.h

* corrected format to match convention instead of xd75 where I accidentally started from

* fixed errors and added arrows bottom right to match my other layouts

* updated readme

* right arrow fix

* Update keyboards/idobo/keymaps/greenshadowmaker/keymap.c

removing unnecessary part, copied from different keymap

Co-Authored-By: fauxpark <[email protected]>

* added suggested changes

* removed unneded elements
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@GreenShadowMaker @mechmerlin
keymap for idobo (qmk#6250)
0d5f0d5 
* greenshadowmaker keymap for idobo xd75 massdrop

* remove uneeded config.h

* corrected format to match convention instead of xd75 where I accidentally started from

* fixed errors and added arrows bottom right to match my other layouts

* updated readme

* right arrow fix

* Update keyboards/idobo/keymaps/greenshadowmaker/keymap.c

removing unnecessary part, copied from different keymap

Co-Authored-By: fauxpark <[email protected]>

* added suggested changes

* removed unneded elements
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@GreenShadowMaker @JeffreyPalmer
keymap for idobo (qmk#6250)
1095dc9 
* greenshadowmaker keymap for idobo xd75 massdrop

* remove uneeded config.h

* corrected format to match convention instead of xd75 where I accidentally started from

* fixed errors and added arrows bottom right to match my other layouts

* updated readme

* right arrow fix

* Update keyboards/idobo/keymaps/greenshadowmaker/keymap.c

removing unnecessary part, copied from different keymap

Co-Authored-By: fauxpark <[email protected]>

* added suggested changes

* removed unneded elements
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@GreenShadowMaker @swamp09
keymap for idobo (qmk#6250)
1f97378 
* greenshadowmaker keymap for idobo xd75 massdrop

* remove uneeded config.h

* corrected format to match convention instead of xd75 where I accidentally started from

* fixed errors and added arrows bottom right to match my other layouts

* updated readme

* right arrow fix

* Update keyboards/idobo/keymaps/greenshadowmaker/keymap.c

removing unnecessary part, copied from different keymap

Co-Authored-By: fauxpark <[email protected]>

* added suggested changes

* removed unneded elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GreenShadowMaker @fauxpark @noroadsleft @mechmerlin