Fixed Tanuki RGB lighting #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Aug 4, 2019
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Aug 6, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (240 commits) Move maartenwut's keyboards to one folder (qmk#6484) GH60 Refactor: Move Satan into GH60 directory (qmk#6485) Remove unused _BOOTLOADER defines [Keyboard] add keyboard-discipline (qmk#6464) [Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479) [Keymap] Add some more commonly used symbols to melody96/zunger. (qmk#6478) [Keyboard] WT75-A & WT75-B fixes for QMK Configurator (qmk#6472) [Keymap] update to dsanchezseco keymap (qmk#6470) [Keymap] Fixed Tanuki RGB lighting (qmk#6462) Add iS0 Keypad (qmk#6456) [Keymap] jotix ortho_4x12_layout (qmk#6458) [Keyboard] New Keyboard: KBDPad MKI (qmk#6452) [Keymap] Adds Keymap for Iris/blucky (qmk#6449) [Keymap] Fixing Sol Rev2 default keymap OLED rotation. (qmk#6448) [Keyboard] QWERTYYdox refactor (qmk#6446) [Keymap] Adds keymap for muzfuz/lunar (qmk#6432) [Docs] Add dfu-util and caterina udev examples (qmk#6429) updates to akb/raine in ready for production units (qmk#6457) Removed print call to resolve qmk#6364 (qmk#6413) Fix typo for building Ergodox EZ keyboards (qmk#6453) ...
Acaki
pushed a commit
to Acaki/qmk_firmware
that referenced
this pull request
Aug 6, 2019
incredibleweirdo
pushed a commit
to electricbrainreserve/qmk_firmware
that referenced
this pull request
Aug 15, 2019
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default keymap so far used very inefficient and kinda unreadable code to handle per-layer RGB switching. Hooking into matrix scan, overlaying layers, etc. Moreover, it actually writes to EEPROM constantly - originally we thought with every layer change, but it turns out it actually writes on every keypress.
This completely reworks the RGB code, which is now based mostly on what's provided in QMK docs as an example. Functionality stays the same, but it should be much less of a resource hog and not kill Pro Micros after a short while. As an added benefit the toggle for per-layer RGB switching now persists after restart or disconnection of keyboard.
I'd like to thank @Haptick#1749 from 40% Discord for testing this with me and making sure everything works as it should.
Types of Changes
Issues Fixed or Closed by This PR
Checklist